[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-04-13 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @dejanb I will merge this PR, if you really want to fix this test you may bring it back later. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-04-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @mtaylor I was going to remove this, then @dejanb said he would look at fixing the test instead... @dejanb what should we do? fix the test or remove it as I'm patching it h

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-04-11 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @clebertsuconic I'm not sure what has happened here. Is this patch still relevant? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-03-29 Thread dejanb
Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @clebertsuconic I found original Jiras why this test was added https://issues.apache.org/jira/browse/AMQ-4884 https://issues.apache.org/jira/browse/AMQ-5074 I think we s

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 Actually the test failing contradicts the test you added on openwire/MQTT... so I will just remove the test... --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

2017-03-28 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1150 @dejanb I'm fixing a test here, accordingly to a bisect it was broken at 21b64b3... Your change was correct.. so I'm not sure if the test is invalid.. or if there's somethi