Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
The only change to test is adding line
`commonSettings.setExpiryAddress(dla);` in broker creation. That causes the
test to progress further (passes assert) and then the test tries to cast
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
@jdanekrh sure, but I'm wondering if this test should be left alone.
perhaps just fixing that would be enough to fix this test?
---
If your project is set up for it, you can reply
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
I'd prefer to put the fix into a new PR, if you don't mind. I think there
is already enough things in this one already.
---
If your project is set up for it, you can reply to this email
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
@jdanekrh if it's a bug on these acks, then lets kep this test the way it
is then... or ammend this PR with this fix you mentioned instead. I think it's
right.. we just need to run
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
Right. Yeah, I think this one is actual OpenWire handling bug in Artemis.
If the message expires while it is being prefetched on client, server drops it
and never tries to expire it.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
>>> If it expired on client, how would it then get to DLQ queue on server?
There's a special protocol on OpenWire to tell the server the message
expired. On Artemis we would
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
> messages only expire on client on activemq5 while it's on server & client
on artemis
Did you mean expire on _server_ on activemq5? If it expired on client, how
would it then ge
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
the test would take the consideration the messages only expire on client on
activemq5 while it's on server & client on artemis. I had seen some other tests
failing because of that..
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
> it's probably an issue on the test.
I was not sure. The same test is passing with ActiveMQ 5.
---
If your project is set up for it, you can reply to this email and have your
re
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
it's probably an issue on the test.
should I merge this already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
10 matches
Mail list logo
