[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...

2017-08-03 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @clebertsuconic Yes I need to run the whole test suite, add some others tests to see if it is working as expected plus provides the NIO version too. What I'm not understanding is

[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...

2017-08-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @franz1981 I feel like you should do more tests before merging this Franz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...

2017-08-02 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @franz1981 what about replacing the TimedBuffer from another delegating buffer that would call the callbacks? Now, you have to make sure that callbacks from replication woul

[GitHub] activemq-artemis issue #1436: ARTEMIS-1318 Uses unbuffered MAPPED Journal if...

2017-08-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @clebertsuconic I'm just concerned about the callbacks behaviour...do you have any advices? --- If your project is set up for it, you can reply to this email and have your reply appear