[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 @Matze2 the broker plugin is basically intercepting the message. I used the term out of the concept instead of the class name. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I was not even aware that there is somewhere a binary snapshot to download. I compiled it myself (had to add servlet-api dependency to artemis-rest module to be able to build it).

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I think the snapshot wasn’t updated yet. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 Ignore my last message. I was irritated by the pull request title containing the word "interceptor". The JIRA issue is named differently. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-12 Thread Matze2
Github user Matze2 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I tried the latest snapshot with an AmqpInterceptor implementation. This does not work. ``` @Override public boolean intercept(final AMQPMessage message, RemotingConnecti

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread harrison-tarr
Github user harrison-tarr commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 @clebertsuconic it looks good to me. It might be worth adding a note in the https://activemq.apache.org/artemis/docs/latest/broker-plugins.html document about this example ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 @harrison-tarr mind reviewing the doc I wrote? ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread harrison-tarr
Github user harrison-tarr commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 I pulled this down and tested it with my ServerPlugin and AMQP producer/consumer code. I'm no longer seeing the issue I was before, so I think this fixes it 🎉 ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 @tabish121 I have changed docs around to address your point ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 We would need to change putProperties to forbid it. All we can do is document it. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 Users can do that already today. Not introducing anything new. Not recommended. But users can do that already. ---

[GitHub] activemq-artemis issue #1584: ARTEMIS-1461 Allow changing of messages throug...

2017-10-11 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1584 So I don't see any documentation explaining how this violates the AMQP specification about the immutability of the bare message part of the AMQP message, or how it can now can present a