[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

2017-11-15 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1657 yeah thats fine, cheers ---

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

2017-11-15 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1657 @andytaylor ok.. the issue is just duplicated now ... I can take care of the other property. What would be a better commit description here? "NO-JIRA Adding Advisor

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

2017-11-15 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1657 I just moved these tests from another class and added slightly different assertion. ---

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

2017-11-15 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1657 @andytaylor Could you ammend the commit message to something more descriptive please. ---