[GitHub] activemq-artemis issue #1761: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

2018-12-18 Thread JiriOndrusek
Github user JiriOndrusek commented on the issue: https://github.com/apache/activemq-artemis/pull/1761 I agree, closing as requested in previous comment. ---

[GitHub] activemq-artemis issue #1761: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

2018-12-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1761 @JiriOndrusek, I don't think this is going to get merged. Can you go ahead and close this PR? ---

[GitHub] activemq-artemis issue #1761: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

2018-01-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1761 -1000 on this PR... it's a brittle change over a test failure. .you could find other way to fix the test? it's a huge change on the maintenance 1.x branch...

[GitHub] activemq-artemis issue #1761: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

2018-01-09 Thread JiriOndrusek
Github user JiriOndrusek commented on the issue: https://github.com/apache/activemq-artemis/pull/1761 In 2 places I have to use "constant" for repetitive checking, whether action is already finished. May I use some generic timeout used in project (or define new attribute, ...)