[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-09-06 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 @michaelandrepearce Sorry for the late reply. I rebase the code and tests pass. ---

[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-07-31 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 @wy96f can you look at the failed build? Ideally need a succesful pr build to merge ---

[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-07-03 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 Test resolved:) ---

[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-07-02 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 @wy96f, the test you added has a lot of checkstyle violations. Please resolve. ---

[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-06-29 Thread wy96f
Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 Hi, michaelandrepearce, thanks for review, test has been added to validate the issue:) ---

[GitHub] activemq-artemis issue #2155: ARTEMIS-1949 fix IllegalMonitorStateException ...

2018-06-29 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2155 Could a test case be added to capture the issue, and therefor also validate the fix and ensure no future regression? ---