[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-12-17 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 Delivery annotations are for per-hop usage, so the brokers the only thing that should be adding delivery annotations to messages it is sending. ---

[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-12-17 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 @jbertram yes, the broker can add additional message annotations as long as those being added follow the rules from the spec, if the user adds something that the remote doesn't understan

[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-12-16 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 @tabish121, is it OK by the AMQP 1.0 spec for the broker to add delivery annotations? ---

[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-10-02 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 Rebased and updated after the refactorings done in #2329. ---

[GitHub] activemq-artemis issue #2256: ARTEMIS-2045 Add support for setting delivery ...

2018-09-24 Thread calohmn
Github user calohmn commented on the issue: https://github.com/apache/activemq-artemis/pull/2256 Any comments on this? For the case that the newly introduced `outgoingDeliveryAnnotations` have not been set, the code is still the same as before. I only have adapted some comments an