[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-12-18 Thread xcorail
Github user xcorail commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 Hello @jbertram Done ---

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-12-18 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 I don't think there's currently any plan to merge this. Could you close this PR, @xcorail? ---

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-06 Thread xcorail
Github user xcorail commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 > I'm dubious about users selecting a project based on the code quality rating from lgtm.com Thanks for this feedback. This is something we are trying to assess atm. If you have

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 I'm dubious about users selecting a project based on the code quality rating from lgtm.com, but I am interested in the pull-request integration as I can think of at least one mistake it

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-05 Thread xcorail
Github user xcorail commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 Hi @jbertram The code quality grade, or grade, is an estimation of the relative quality of a project when compared to similar reference projects. It is a letter between A+ and E

[GitHub] activemq-artemis issue #2290: Add LGTM code quality badges

2018-09-04 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2290 I couldn't find a description of what the grades on the badges actually mean. Do you have any idea about that? ---