[GitHub] activemq-artemis issue #2338: ARTEMIS-2101 Do not cluster OpenWire advisory ...

2018-10-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2338 @michaelandrepearce @jbertram @clebertsuconic I have made it more generic and less OpenWire bounded, but I'm not quite 100% sure about it so please, fi you have any comments or worries s

[GitHub] activemq-artemis issue #2338: ARTEMIS-2101 Do not cluster OpenWire advisory ...

2018-10-02 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2338 Thanks guys: I'm working on this to improve the decoupling of the solution from being OpenWire-centric :+1: ---

[GitHub] activemq-artemis issue #2338: ARTEMIS-2101 Do not cluster OpenWire advisory ...

2018-10-01 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2338 @jbertram ++ Add a method on ProtocolManager, changeFilter, or changeClusterManager. run it on all the protocols to that. For example that will be an issue wit

[GitHub] activemq-artemis issue #2338: ARTEMIS-2101 Do not cluster OpenWire advisory ...

2018-10-01 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2338 Perhaps the OpenWireProtocolManager could change the filter of the cluster connection when it's started or it could register an ActivateCallback and do the changes there. ---

[GitHub] activemq-artemis issue #2338: ARTEMIS-2101 Do not cluster OpenWire advisory ...

2018-10-01 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2338 Point here is this could be something on the address that could be made much more generic. We shouldnt do anything thats protocol specific in core. We should find a generic way