[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-05 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 @franz1981 This looks good to me. Merging. ---

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 Ive reviewed and this looks fine to me. Most of the changes are non intrusive ---

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-04 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 I have verified that the new test failures are intermittent failures, so this PR seems safe enough although I suppose it need to be reviewed given the amount of changes ---

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-04 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 I'm checking on the Ci if the failing tests are intermittent ones: ![image](https://user-images.githubusercontent.com/13125299/47961493-6c89ce00-e00c-11e8-8225-17067e34eb34.png) O

[GitHub] activemq-artemis issue #2414: ARTEMIS-1710 Allow management msgs to exceed g...

2018-11-03 Thread franz1981
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2414 @clebertsuconic @mtaylor @michaelandrepearce This PR is considering the management addresses as pure broker infrastructure (like any other broker internal mechanics that could alloca