[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-09 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/573 @jbertram there are methods on the thread-leack-checker to add known thread names as well. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-09 Thread mtaylor
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/573 @jbertram @clebertsuconic I've had issues with the thread checker when using JDBC. Often the driver will create some background thread that manages dead connections, clean up etc... and is

[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-08 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/573 The issue with the threads is that org.apache.directory.server.core.integ.FrameworkRunner which is being used for @RunWith is managing the LDAP server and I believe by the time the thread

[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-08 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/573 actually since this is only affecting tests (not any production code) it's better until the release is out (tomorrow) to merge it. I know Martyn will be respining the release

[GitHub] activemq-artemis issue #573: Fix possible leaks in LDAP tests

2016-06-08 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/573 @jbertram I will merge it, but if I added this following line in one of these tests: ```java @Rule public ThreadLeakCheckRule leakCheckRule = new Threa