Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bayern39 commented on the pull request:
https://github.com/apache/activemq-artemis/pull/517#issuecomment-219450061
@jbertram i have fixed it,thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/517#discussion_r63352943
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/management/impl/JMSConnectionFactoryControlImpl.java
---
@@ -432,6
Github user bayern39 commented on the pull request:
https://github.com/apache/activemq-artemis/pull/517#issuecomment-219415936
@mtaylor OK,i did it ,thanks for your tip!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/517#issuecomment-219387544
@bayern39 Hi, you have several check style issues in your commit. Could
you please fix these. To find these locally build with the dev profile
`mvn
GitHub user bayern39 opened a pull request:
https://github.com/apache/activemq-artemis/pull/517
ARTEMIS-519 protocol-manager-factory is not implemented on
ConnectionFactoryControl
https://issues.apache.org/jira/browse/ARTEMIS-519
You can merge this pull request into a Git
