Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99980734
There was a mistake on extra-tests/pom.xml... a comment that was removed by
accident.
---
If your project is set up for it, you can reply to this email
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/235
Hornetq protocol support
This is a repost of #227 with a small fix on the extra-tests/pom.xml
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/227
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99900168
Martyn, can you rebase your PR? There are some fixes merged recently that
you need for the PR build to finish successfully.
---
If your project is set up
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99412764
Please hold off merging this for now. @andytaylor has asked me to do some
performance testing on the usage of interceptors vs overriding methods in the
Github user andytaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99430232
personally I wouldn't have used Interceptors. Its a level of indirection
that isn't really needed. I would just have used abstraction and catch the
packets
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99431498
The test consisted of sending a million empty messages 5x, taking average
time. The test is in no means 100% accurate as it was running on my dev laptop
with
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/227
HornetQ Protocol Support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis hornetq-support
Alternatively you
Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/227#discussion_r29698636
--- Diff:
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99188011
@mtaylor this PR is not valid... there are a few checkstyle and a missing
license header as @johnament mentioned (although the PR check would have
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99195052
@johnament actually header check is disabled on the build.. we are fixing
it back... thanks for raising the issue
---
If your project is set up for
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/227#discussion_r29711018
--- Diff:
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99164100
Build failure...
The right name is Legacy Protocol Support... I would avoid the H name now
:8ball:
---
If your project is set up for it, you
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99168844
protocol/src/main/java/org/apache/activemq/artemis/core/protocol/hornetq/HQPropertiesConversionInterceptor.java:12:
Using the '.*' form of import should
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99220614
@clebertsuconic Looks like IntelliJ settings are screwing things up. I'll
get to this tomorrow.
---
If your project is set up for it, you can reply to this
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/227#issuecomment-99225003
@mtaylor cool... also please make sure you rebase on top of master
tomorrow as I have merged a few other PRs today.
---
If your project is set up for
17 matches
Mail list logo
