when releasing (duh)
They're off for everything else.
Justin
[1] https://github.com/apache/activemq-artemis/pull/231
- Original Message -
From: "Timothy Bish"
To: dev@activemq.apache.org
Sent: Wednesday, May 6, 2015 9:35:51 AM
Subject: Re: Artemis with License Checks on PR
On 05/06/2015 10:24 AM, Andy Taylor wrote:
> which I think is fine. it doesnt matter for users who are just
> building from source, its only an issue for contributions which the PR
> build is there to catch
Agreed, the users should be able to work however they are comfortable
and let the automatio
, May 6, 2015 9:22:32 AM
Subject: Re: Artemis with License Checks on PR/s build
As it has happened.. we had a few issues on the github already that we
needed to fix.
On Wed, May 6, 2015 at 10:21 AM, Clebert Suconic
wrote:
> That's the kind of thing that won't happen.. people will ju
which I think is fine. it doesnt matter for users who are just building
from source, its only an issue for contributions which the PR build is
there to catch
On 06/05/15 15:21, Clebert Suconic wrote:
That's the kind of thing that won't happen.. people will just ignore it
On Wed, May 6, 2015 a
As it has happened.. we had a few issues on the github already that we
needed to fix.
On Wed, May 6, 2015 at 10:21 AM, Clebert Suconic
wrote:
> That's the kind of thing that won't happen.. people will just ignore it
>
> On Wed, May 6, 2015 at 10:18 AM, Andy Taylor wrote:
>> or document how to en
That's the kind of thing that won't happen.. people will just ignore it
On Wed, May 6, 2015 at 10:18 AM, Andy Taylor wrote:
> or document how to enable it so users can turn it on if they want
>
>
> On 06/05/15 15:16, Clebert Suconic wrote:
>>
>> The thing is.. we will have more failures on the PR
or document how to enable it so users can turn it on if they want
On 06/05/15 15:16, Clebert Suconic wrote:
The thing is.. we will have more failures on the PR builds.. .I would
rather have people getting issues at their code.
Perhaps you could just document how to disable on README.. and make
The thing is.. we will have more failures on the PR builds.. .I would
rather have people getting issues at their code.
Perhaps you could just document how to disable on README.. and make it
easy for users to disable it.
On Wed, May 6, 2015 at 10:14 AM, Andy Taylor wrote:
> Personally I prefer i
Personally I prefer it just to be run on PR's, not everyone that build
from source is bothered about it. I think users should be able to build
from source no matter what they have in their source tree, log files,
users own source etc.
On 06/05/15 14:54, Clebert Suconic wrote:
So, the poms now
So, the poms now have the RAT check enabled. That means we would get
our own mistakes instead of wasting server's time resource with a
failed PR.
I think that's the right way to do it... we wouldn't waste server's
time resource on failed PRs... and wouldn't waste anyone's time on
looking at PRs for
Just a heads up,
Justin Bertram has enabled license checks on the build again, and the
PR checks...
So, from now on committing java files without headers won't get un
noticed without a build failure ;)
11 matches
Mail list logo
