Re: AMQ-7006

2018-07-23 Thread Gary Tully
doing many thousand iterations of the problematic code path using external api and verifying the vm memory usage after a few gc cycles usually identifies a memory leak. see an example here: https://github.com/apache/activemq/blob/57795bafcea290c6879bb288822435c480a9212d/activemq-unit-tests/src/test

Re: AMQ-7006

2018-07-09 Thread Avikash Mishra
Hi Gary, The issue I’m trying to fix is a memory leak in ProtocolConverter.java I can’t seem to find any tests that use this file or the StompSubscription.java file. The problem is the pedingAcks array in ProtocolConverter.java is not getting cleaned up when we ACK in client mode. The garbage

Re: AMQ-7006

2018-07-04 Thread Gary Tully
see: org.apache.activemq.transport.stomp.Stomp12Test https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=blob_plain;f=activemq-stomp/src/test/java/org/apache/activemq/transport/stomp/Stomp12Test.java;hb=HEAD On Tue, 3 Jul 2018 at 23:47 Avikash Mishra wrote: > Hi Gary, > > Thanks for your re

Re: AMQ-7006

2018-07-03 Thread Avikash Mishra
Hi Gary, Thanks for your reply. Is there any tests I can leverage off? I need to test the onStompMessageAck method in StompSubsrcription.java class. Or if you can point me in the right direction. Thanks Avikash > On 3/07/2018, at 9:14 PM, Gary Tully wrote: > > please add a unit test that

Re: AMQ-7006

2018-07-03 Thread Gary Tully
please add a unit test that will demonstrate the problem and fix and also protect it. On Tue, 3 Jul 2018, 06:04 Avikash Mishra, wrote: > Hi there, > > We have been having the issue mentioned here > https://issues.apache.org/jira/browse/AMQ-7006 > > I have attached a patch. Please review and get