Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-05 Thread via GitHub
mingfang commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2040147467 @jrgemignani Confirm fixed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-05 Thread via GitHub
mingfang closed issue #1709: `MERGE` creates incomplete vertices after the first one URL: https://github.com/apache/age/issues/1709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-05 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2040011319 @diangamichael Thank you for your input. However, this issue is a bug and the suggestion is a temporary workaround. This issue cannot be closed until the issue is resolved and @mingf

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2038182979 @mingfang I found the issue and corrected it. Although, I need to review that it is correct and there aren't other areas that may have a similar issue. Here is a sample output

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2037870324 @mingfang Don't get too carried away ;) it is just a temporary workaround. We shouldn't need to run SET twice to get it to work. -- This is an automated message from the Apache Git

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2037711286 @mingfang From the example above I have a possible workaround for you while I figure out what the issue is with the ids - ``` psql-16.1-5432-pgsql=# SELECT * FROM cypher('pl

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2037659914 @jtomek ON CREATE or ON MATCH may be good to add to Apache AGE. You should consider opening a separate discussion thread about them to see what others might think. Unfortunat

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2037643171 @sir-sa Respectfully, that is not how SET works internally nor is it the cause of this issue. What is interesting, though, is that your query works. But, it also works without the co

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-04 Thread via GitHub
jtomek commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2037568630 I second the idea of implementing ON CREATE and ON MERGE. This would significantly help with business logic needed to prevent duplicates. A few neo4j examples as food for though

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-03 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2035889590 @mingfang Yeah, it appears to be an issue with transaction/command ids. It likely has to do with the handoff between MERGE and SET as both are updates. -- This is an automated mess

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-03 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2035590623 @diangamichael Could you, in addition to your response, include an example using Apache AGE showing this solves the issue? -- This is an automated message from the Apache Git Servi

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-03 Thread via GitHub
diangamichael commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2035541941 The issue you're encountering is because of the way you're merging and setting properties in your Cypher query. When you use MERGE, it will only create a new node if it doesn't alr

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-03 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2035535378 @mingfang I traced the code and found it skipping the insert for the latter tuple. This looks to be a transaction/command id issue. -- This is an automated message from the Apache

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-02 Thread via GitHub
mingfang commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-206284 My real use case is to create a graph from a SQL query and I don't know ahead of time what fields are returned. This is my function to run SQL and return Agtype ```sql -- Apache

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-02 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2033310671 @mingfang Question - Just curious, why are you doing it this particular way? If you use merge as follows, it works - ``` psql-16.1-5432-pgsql=# SELECT * FROM cypher('playgro

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-02 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2033303516 @mingfang I will look into this one. It looks like it is creating the correct return tuple, just not inserting the correct tuple. I sometimes think that I should just rewrite merge a

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-02 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-203339 @mingfang Oops, nvm, sigh,... ``` psql-16.1-5432-pgsql=# SELECT * FROM cypher('playground', $$ psql-16.1-5432-pgsql$# MATCH (v:PERSON) psql-16.1-5432-pgsql$# RETURN

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-04-02 Thread via GitHub
jrgemignani commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2033297890 @mingfang It looks like maybe my PR #1718 might have fixed this one too?! This is in the master branch, btw. ``` psql-16.1-5432-pgsql=# SELECT create_graph('playground');

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-03-26 Thread via GitHub
Akaza20-03 commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2020006870 I think we can fix this issue by explicitly assign each property indivisually in merge operation //previous line SET v=map //updated line SET v.first=map.first ,

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-03-24 Thread via GitHub
mingfang commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2017304543 @anfa-majid In my specific test case above, `first` does uniquely identify the vertex. I think the problem is much deeper(and more serious) than what you described. -- This is a

Re: [I] `MERGE` creates incomplete vertices after the first one [age]

2024-03-24 Thread via GitHub
anfa-majid commented on issue #1709: URL: https://github.com/apache/age/issues/1709#issuecomment-2017231086 The issue you're encountering with MERGE creating incomplete vertices stems from the way the MERGE and SET commands are being applied. In your query, MERGE is used with a condition th