Hard to say as we have no stats but even in our very own airflow examples
we have plenty of "from airflow.models import DAG":
grep -R 'from airflow.models import DAG' .
./example_latest_only.py:from airflow.models import DAG
./example_python_operator.py:from airflow.models import DAG
./test_utils.
Any cyclic imports we have aren't actually a problem and are handled fine by
python 3 (obviously, else it wouldn't work) so I think this is a big in sphinx
with it being over zealous.
This only affects tests and development, not our users in this case.
If it's difficult to fix I would go with p
Don't most people do `from airflow import DAG` (i.e. they don't import it from
models but airflow)?
On 24 June 2019 00:07:49 BST, Jarek Potiuk wrote:
>Just few comments to spark a discussion about backwards compatibility
>for
>this proposal:
>
>- Airflow uses Alembic to generate automated migra
Anything inheriting from airflow.models.base.Base is found by Alembic,
regardless the location of the script.
Bas
> On 24 Jun 2019, at 01:07, Jarek Potiuk wrote:
>
> Just few comments to spark a discussion about backwards compatibility for
> this proposal:
>
> - Airflow uses Alembic to gener
@Ash Berlin-Taylor ?
On Mon, Jun 24, 2019 at 1:37 AM Jarek Potiuk
wrote:
> Hello Everyone,
>
> We have yet another case where relesing a package (Sphinx 2.1.2 in this
> case) - started to cause master to fail.
>
> Should we pin Sphinx to an earlier version or maybe someone can help and
> figur
Hello Everyone,
We have yet another case where relesing a package (Sphinx 2.1.2 in this
case) - started to cause master to fail.
Should we pin Sphinx to an earlier version or maybe someone can help and
figure out and fix it quickly (seems that there are some cyclic imports
that probably need sol
Just few comments to spark a discussion about backwards compatibility for
this proposal:
- Airflow uses Alembic to generate automated migration scripts. Not sure
where it takes all the models from to generate the scripts (__init__ in
airflow.models maybe, or simply by scanning all classes). I do
Congrats Kaxil!
Have nice time! :)
Deng Xiaodong schrieb am So., 23. Juni 2019, 05:32:
> Congrats Kaxil. Have a nice marriage vacation!
>
> XD
>
> > On 23 Jun 2019, at 5:41 AM, Bas Harenslak
> wrote:
> >
> > Congrats Kaxil on both events!
> >
> > Bas
> >
> > On 22 Jun 2019, at 11:53, Felix Ue
