Re: Proposal: Automatically mark stale PRs in github

2019-07-01 Thread Driesprong, Fokko
Great work Jarek. I think the stalebot is a great addition. Even if an issue gets closed unresolved, it is an indication to me that the issue might not be relevant. In the end you can always reopen issues again. Cheers, Fokko Op di 2 jul. 2019 om 07:41 schreef Jarek Potiuk > If we finally find

Re: [VOTE] Labelling scheme for the upcoming official docker images of Airflow

2019-07-01 Thread Jarek Potiuk
Just to remind - the vote is up till Thursday 7am CEST. W have so far +3 binding +5 non-binding votes so for now the status is PASS. Thanks for all who participated :). I encourage others as well. Anticipating positive vote I already implemented the scheme in the upcoming final commit from AIP-10

Re: [PROPOSE] Introduce and encourage pre-commit hooks framework to Airflow developer workflow

2019-07-01 Thread Kaxil Naik
+1 We have been using this on some of our Astronomer repositories as well and have been happy with it. Regards, Kaxil On Tue, Jul 2, 2019, 11:46 Jarek Potiuk wrote: > TL;DR: I would like to make a proposal to add (easily managed) pre-commit > hooks with various lint checkers part of recommende

[PROPOSE] Introduce and encourage pre-commit hooks framework to Airflow developer workflow

2019-07-01 Thread Jarek Potiuk
TL;DR: I would like to make a proposal to add (easily managed) pre-commit hooks with various lint checkers part of recommended (and encouraged) development workflow for Airflow. This will help with speeding-up local development cycle and decrease pressure on Travis CI. Over the last few months in

Re: Proposal: Automatically mark stale PRs in github

2019-07-01 Thread Jarek Potiuk
If we finally find out why stale bot does not work - the issue is still not solved - stale bot has a number of feature that make management of the issues easy. And it is super-lightweight and helps to work in a community-compatible way. No need to have single person managing everything as long as w

Re: [DISCUSS] Apache Airflow website requirements

2019-07-01 Thread Kamil BreguĊ‚a
I read the document and left a few simple comments. I would like us to discuss about three things. 1. Architecture from the technical side. I'm not sure if it's about creating a Airflow's site or creating documentation for Airflow. For me, these are two independent things. Pytorch consist of mult

Re: [VOTE] Release Airflow 1.10.4 from RC2

2019-07-01 Thread Ash Berlin-Taylor
I didn't finish writing the subject. Updated :) > On 1 Jul 2019, at 19:52, Ash Berlin-Taylor wrote: > > Hello Airflow community, > > I have fixed up the error from RC1 (leaving in a `ipdb.set_trace`) and pulled > in a few extra fixes/improvements and have now cut 1.10.4 RC2 > > This email is

[VOTE]

2019-07-01 Thread Ash Berlin-Taylor
Hello Airflow community, I have fixed up the error from RC1 (leaving in a `ipdb.set_trace`) and pulled in a few extra fixes/improvements and have now cut 1.10.4 RC2 This email is calling a vote on the release, which will last for 72 hours (2019-07-04 18:52 Z), and until three binding votes have

Re: [VOTE] Release Apache Airflow 1.10.4rc1 as 1.10.4

2019-07-01 Thread James Meickle
I implemented the toggle wrap button primarily for the log view. As I noted in the PR, there isn't a trivial fix for line number wrapping for the code view: the generated HTML is a massive 2x1 table, where there's one cell with all the numbers and one cell with all the lines. To fix this, we'd need

Re: Proposal: Automatically mark stale PRs in github

2019-07-01 Thread Kaxil Naik
Don't know if we can configure the stable to ping the commiters (not all but some) twice before closing a PR. On Mon, Jul 1, 2019, 15:25 Ash Berlin-Taylor wrote: > An example of why I'm not a _huge_ van of stale bot, at least not for > issues. > > https://github.com/dpgaspar/Flask-AppBuilder/iss

Re: Proposal: Automatically mark stale PRs in github

2019-07-01 Thread Ash Berlin-Taylor
An example of why I'm not a _huge_ van of stale bot, at least not for issues. https://github.com/dpgaspar/Flask-AppBuilder/issues/685 That is still an issue but was closed just because no one responded to it. > On 11 Jun 2019, at 06:50, Jarek Potiuk wrote: > > This issue bugs me a lot. Pretty