Re: Debugging inconsistent Travis Failures

2019-10-02 Thread Kamil BreguĊ‚a
Hello, We know that there is some problem with the stability of some tests and we try to limit this problem. * migration from nose to pytest. In the meantime, a large number of sideeffects will be deleted. * migration from Travis Ci to GitLab Ci on GKE. This will increase the computing power that

Debugging inconsistent Travis Failures

2019-10-02 Thread Leah Cole
Hi all, I submitted a small PR today that's been approved, but am having trouble with Travis - the first time the job ran, the "Tests postgres kubernetes python 3.6 (git)" task failed. Someone generously reran it, and this time the "Tests mysql python

Re: How to manage Airflow SIGTERM excetion catches?

2019-10-02 Thread Alex Guziel
Task_copy.on_kill() should probably be killing the underlying process, but I think it's fuzzy where the exception gets thrown. I think the intention is for the exception to get caught in that same block, so the cleanup can happen, but this is not the case since it is thrown in the main thread. I th

Re: How to manage Airflow SIGTERM excetion catches?

2019-10-02 Thread Alex Guziel
Actually, reading the docs, the handler throws it in the main thread. In that case we should definitely change it to subclass SystemExit, or just use System.exit On Wed, Oct 2, 2019 at 12:53 PM Alex Guziel wrote: > It's been a while since I've looked at this code, but the exception thrown > ther

Re: How to manage Airflow SIGTERM excetion catches?

2019-10-02 Thread Alex Guziel
It's been a while since I've looked at this code, but the exception thrown there is thrown from a place where it should not be able to be caught by your operator code, so the issue may be somewhere else. On Wed, Oct 2, 2019 at 12:41 PM Shaw, Damian P. < damian.sha...@credit-suisse.com> wrote: > T

How to manage Airflow SIGTERM excetion catches?

2019-10-02 Thread Shaw, Damian P.
Today I had an issue where my operator caught the SIGTERM exception that Airflow throws. It seems to me that Airflow shouldn't be throwing a SIGTERM exception that subclasses Exception, particular as in arbitrary Python functions this might happen commonly. The code in my operator looked like t

Re: Warsaw Apache Airflow Meetup

2019-10-02 Thread Aizhamal Nurmamat kyzy
Thanks Fokko for adding it to the wiki! Tomasz, sorry I missed your email, please send your talk title, abstract and bio (also a headshot if you have) to me. I will update the meetup page with it. Thanks On Mon, Sep 30, 2019 at 4:34 AM Tomasz Urbaszek wrote: > Hi, > > I would like to give a tal

Merging PRs

2019-10-02 Thread Kaxil Naik
Hello, all committers & PMC members, Whenever your merge PRs, please make sure that the commit message follows the following structure: *[AIRFLOW-XXX] COMMIT_MSG (#PR_NUMBER)* Example: *[AIRFLOW-5574] Fix Google Analytics script loading (#6218)* This will make our Changelog easy to read too :)