[DISCUSS] Approach for JIRA [AIRFLOW-5523]

Hi Team I am working on JIRA AIRFLOW-5523 . As per the JIRA, the requirement is to automate the deletion for the dags whose dag file is not present. In the current state, when a user tries to delete a dag from UI whose file is already present,

[DISCUSS] Approach for JIRA [AIRFLOW-5523]

Hi Team I am working on JIRA AIRFLOW-5523 . As per the JIRA, the requirement is to automate the deletion for the dags whose dag file is not present. In the current state, when a user tries to delete a dag from UI whose file is already present,

Re: [VOTE] Allow using asserts in Airflow code

-1 (binding) I share the same with most other comments. And I personally prefer to use try,except to make it consistent across the code base while use assert in unit test . On Thu, Dec 5, 2019 at 3:09 PM Felix Uellendall wrote: > -1 (binding) > > I agree. There shouldn’t be any confusion around

2020 ASF Community Survey

Hello everyone, If you have an apache.org email, you should have received an email with an invitation to take the 2020 ASF Community Survey. Please take 15 minutes to complete it. If you do not have an apache.org email address or you didn’t receive a link, please follow this link to the survey: h

Re: [VOTE] Allow using asserts in Airflow code

-1 (binding) I agree. There shouldn’t be any confusion around this if we want to introduce this. The old/current assertion style still looks more readable to me. Felix Sent from ProtonMail Mobile On Thu, Dec 5, 2019 at 23:35, Kevin Yang wrote: > -1 (binding). > > People in the old thread has

Re: [VOTE] Allow using asserts in Airflow code

-1 (binding). People in the old thread has spoken for me. Specifically in Python, the confusion introduced by using asserts IMO can defeat all the benefits mentioned easily. Kevin Y On Thu, Dec 5, 2019 at 8:27 AM Tomasz Urbaszek wrote: > -1 (non-binding) > > T. > > > On Thu, Dec 5, 2019 at 4:

Re: [VOTE] Allow using asserts in Airflow code

-1 (non-binding) T. On Thu, Dec 5, 2019 at 4:16 PM Deng Xiaodong wrote: > -1 (binding). > > As shared earlier, the benefit it brings may not be enough to break even > for me. And it’s not irreplaceable. > > > XD > > > On 5 Dec 2019, at 11:10 PM, Kaxil Naik wrote: > > > > -1 (binding) it defin

Re: [VOTE] Allow using asserts in Airflow code

-1 (binding). As shared earlier, the benefit it brings may not be enough to break even for me. And it’s not irreplaceable. XD > On 5 Dec 2019, at 11:10 PM, Kaxil Naik wrote: > > -1 (binding) it definitely seems to be a source of confusion and comparing > it to the advantages it provides, I w

Re: [VOTE] Allow using asserts in Airflow code

-1 (binding) it definitely seems to be a source of confusion and comparing it to the advantages it provides, I would be hesitant on using it. On Thu, Dec 5, 2019 at 2:56 PM Jarek Potiuk wrote: > Here is a quick vote on using asserts in Airflow code. > > It is distilled from the discussion > http

[VOTE] Allow using asserts in Airflow code

Here is a quick vote on using asserts in Airflow code. It is distilled from the discussion https://lists.apache.org/list.html?dev@airflow.apache.org. Here are the two options: *[+1]* Allow using asserts in some specific cases.* *[-1]**: Forbid using asserts.* The voting will last till Monday 4

Re: [DISCUSS] Using asserts in airflow code

The world of development never ceases to surprise me. I am honestly quite surprised by almost universal doubts about using asserts :) - but - that's an interesting learning. For me (coming from old C/C++ days) using asserts was pretty common and useful (and not difficult to decide when to use/not u

[ANNOUNCEMENT] just merged Pytest test change

Hello - we just merged the Pytest change (AIP-27 ). This is quite a change (for the better!) on how we all run tests for Airflow. (Hint! It's super-easy now - both in Breeze and your local virtualenv). We will soon sta