Re: [VOTE] Allow using asserts in Airflow code

2019-12-06 Thread Kamil BreguĊ‚a
-1 (non-binding) This can cause too much confusion for new contributor. On Fri, Dec 6, 2019 at 12:05 PM Ash Berlin-Taylor wrote: > +1 (binding) as I've already said :) > > -ash > > > On 6 Dec 2019, at 00:55, Tao Feng wrote: > > > > -1 (binding) > > > > I share the same with most other comments.

Re: [VOTE] Allow using asserts in Airflow code

2019-12-06 Thread Ash Berlin-Taylor
+1 (binding) as I've already said :) -ash > On 6 Dec 2019, at 00:55, Tao Feng wrote: > > -1 (binding) > > I share the same with most other comments. And I personally prefer to use > try,except to make it consistent across the code base while use assert in > unit test . > > On Thu, Dec 5, 2019

Re: [DISCUSS] Approach for JIRA AIRFLOW-5523

2019-12-06 Thread Kaxil Naik
Did you reproduce this issue with the current Airflow Master? I think the issues was solved in master On Fri, Dec 6, 2019, 09:37 Vishesh Jain wrote: > Hi Team > > I am working on JIRA AIRFLOW-5523 > . > > As per the JIRA, the requirement is to

[DISCUSS] Approach for JIRA AIRFLOW-5523

2019-12-06 Thread Vishesh Jain
Hi Team I am working on JIRA AIRFLOW-5523 . As per the JIRA, the requirement is to automate the deletion for the dags whose dag file is not present. In the current state, when a user tries to delete a dag from UI whose file is already present,