Re: Improved CI stability and much more enjoyable Breeze development environment

2020-01-14 Thread Michał Słowikowski
Jarek, wow. Seems to be a great improvement for Breeze and pytests. Great news. Best regards On Mon, Jan 13, 2020 at 10:57 AM Jarek Potiuk wrote: > TL;DR; I have a Green and ready for review PR that should vastly improve > the stability of CI and make our development environment much more > enj

Re: Google Summer of Code Announced. Interested?

2020-01-14 Thread Jarek Potiuk
Absolutely Pablo! I am very interested. I have great experience from GSoD and GSoC will be probably even more fun! I will find some issues that need some love and will apply the labels. Anyone else want to join me :) ? J. On Tue, Jan 14, 2020 at 7:43 PM Pablo Estrada wrote: > Hello everyone, >

Re: Reverting [AIRFLOW-1467] Dynamic pooling

2020-01-14 Thread Jarek Potiuk
Few more hints: - example how to see if any file in "airflow/migrations" folder has been modified - you can see how Kaxil implemented labeler.js. - I believe in order to check if the PR needs rebase you need to check if the first (or last?) commit in the PR has parent = current master

Re: Reverting [AIRFLOW-1467] Dynamic pooling

2020-01-14 Thread Jarek Potiuk
Cool! - Fork Kaxil's boring-cyborg: https://github.com/kaxil/boring-cyborg - you will create PRs from there - Setup environment. It's easy and fairly self-detected if you use IntelliJ or VSCode. Even if not, it boils down to running `npm install`. - run 'npm run dev'. It will run t

Google Summer of Code Announced. Interested?

2020-01-14 Thread Pablo Estrada
Hello everyone, As with every year, the Google Summer of Code has been announced[1], so if there are any committers interested, they can start thinking / preparing projects for students to develop over the summer. It's early in the process for now, but it's good to prepare early : ) I have done t

Re: Reverting [AIRFLOW-1467] Dynamic pooling

2020-01-14 Thread Xinbin Huang
Hi Jarek, I would like to take a try into this. Where should I get started? Thanks Bin On Tue, Jan 14, 2020 at 1:28 AM Jarek Potiuk wrote: > Absolutely - it's great that we have the checks in master :). > > But I am thinking about some solutions already. We actually can do > something using Ka

Re: Stateful Tasks (was Poke Reschedule)

2020-01-14 Thread Chris Palmer
I think some of the discussions about incremental and/or idempotency are confusing the topic and are a distraction from the real question. As I said in my previous reply on this thread, many tasks utilize state that is kept somewhere in order to achieve idempotency in an efficient way. Whether that

Re: Often failing tests in CI (and a way to fix them quickly and future-proof)

2020-01-14 Thread Jarek Potiuk
We have other kerberos-related failures. I disabled temporarily "kerberos-specific" build until I add some more diagnostics and test it. Please rebase to latest master. J. On Tue, Jan 14, 2020 at 7:24 AM Jarek Potiuk wrote: > Seems tests are stable - but the kerberos problem is happening ofte

Re: [NON-TECHNICAL] [DISCUSS] Being even more welcoming community ?

2020-01-14 Thread Jarek Potiuk
> > @Jarek, I'm happy to have a think and make a list of the areas of the > documentation I find most lacking. Would you like me to post that here, or > if we open a Jira ticket would it be better to have it commented there? > It would be great if you can create a JIRA issue and assign me. Thanks!

Re: [NON-TECHNICAL] [DISCUSS] Being even more welcoming community ?

2020-01-14 Thread Jacob Ward
That's great to hear Kaxil, I am looking forward to seeing these improvements! @Jarek, I'm happy to have a think and make a list of the areas of the documentation I find most lacking. Would you like me to post that here, or if we open a Jira ticket would it be better to have it commented there? J

[CVE-2019-12398] Apache Airflow Stored XSS vulnerability in classic UI

2020-01-14 Thread Ash Berlin-Taylor
Versions Affected: <= 1.10.4. Description: In Apache Airflow before 1.10.5 when running with the "classic" UI, a malicious admin user could edit the state of objects in the Airflow metadata database to execute arbitrary javascript on certain page views. The new "RBAC" UI is unaffected. Credit:

Re: Reverting [AIRFLOW-1467] Dynamic pooling

2020-01-14 Thread Jarek Potiuk
Absolutely - it's great that we have the checks in master :). But I am thinking about some solutions already. We actually can do something using Kaxil's probot. While preventing merges for all PRs that have not been rebased to latest master is quite an overkill, but I think we can prevent merging

Re: Reverting [AIRFLOW-1467] Dynamic pooling

2020-01-14 Thread Driesprong, Fokko
Hi Jarek, Hopefully, this doesn't happen too often since the tables should be slowly changing. The solution here is to ask the contributors to rebase their PR more often. I'm happy that this is being caught now, and we don't have multiple heads as before :-) Cheers, Fokko Op ma 13 jan. 2020 om