Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Kaxil Naik
I tried an example with PEP-562 but the autocomplete didn't work in Pycharm and still showed the deprecated function. I agree we should have a deprecation warning before we should have changed it. How about we introduce a deprecation warning in the next version (1.10.10) ? Regards, Kaxil ᐧ On Sa

Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Jarek Potiuk
I also started to use VSCode in parallel on my Chromebook as this is the best way to get devenv running there (and I believe it's now THE most popular IDE - including for Python developers). I can check it there as well. On Sat, Feb 22, 2020 at 6:33 PM Jarek Potiuk wrote: > Right -> the same. Ha

Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Jarek Potiuk
Right -> the same. Happy to double check with your POC :) On Sat, Feb 22, 2020 at 6:16 PM Ash Berlin-Taylor wrote: > > That's a very good point about IDE's, I'll double check how PyCharm behaves > (Guessing PyCharm is the most popular one? PyCharm and IntelliJ are the same > engine under the h

Re: [PROPOSAL] Approach for releasing the backported "providers" packages

2020-02-22 Thread Jarek Potiuk
TL;DR; I have an update to the approach for "backported" packages - I have working solution that should enable to release each "providers" backport package separately from each other and it will help us to release only those packages that are tested rather than everything in one go. This PR is an

Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Ash Berlin-Taylor
That's a very good point about IDE's, I'll double check how PyCharm behaves (Guessing PyCharm is the most popular one? PyCharm and IntelliJ are the same engine under the hood, right?) -a On Feb 22 2020, at 4:58 pm, Jarek Potiuk wrote: > > My proposal here: > > Add in a _getattr_ based lazy impo

Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Jarek Potiuk
> My proposal here: > Add in a _getattr_ based lazy import for DAG to airflow/__init__.py module I am all for it - if we can do it in this way, then it is indeed better for the users. > > Do NOT issue a deprecation warning for this. > > Revert the change to all the imports in example dags etc so

Re: [DISCUSS] Reduce (remove?) automated imports in Airflow 2.0

2020-02-22 Thread Ash Berlin-Taylor
To duplicate/re-iterate my comments from that PR.: I've just realised that PR will remove the from airflow import DAG which means that (almost) every single dag in existince will need to be updated else it will be 100% broken. I can not stress just how much that is a non-starter for me. Breakin