Re: API spec questions

2020-05-12 Thread Ash Berlin-Taylor
1. list is not even close to a valid execution date, so I don't see that as a clash. 2. Respond with 400 Bad Request if URL dag id is not whatever wildcard char we pick. (Is ~ URL safe?) when dag_ids query param is provided. 3. Docs is the answer to that. "This is the same as GET, but allows fo

Re: API spec questions

2020-05-12 Thread Kamil Breguła
Hello, It depends on the specific implementation of the Batch API. The Microsoft API can be used with requests. https://docs.microsoft.com/en-us/graph/json-batching I would not like to add new endpoints to the API due to premature optimization. Adding a new endpoint - /dags/{dag_id}/dagRuns/liss

Re: API spec questions

2020-05-12 Thread Ash Berlin-Taylor
Such a batch endpoint is much much harder for API clients to build requests for, and consume (you can no longer just use cURL/requests/any http client), so I'm not a fan of that On 12 May 2020 17:07:12 BST, "Kamil Breguła" wrote: >On Tue, May 12, 2020 at 3:49 PM Jarek Potiuk >wrote: >> >> My 3

Re: API spec questions

2020-05-12 Thread Kamil Breguła
On Tue, May 12, 2020 at 3:49 PM Jarek Potiuk wrote: > > My 3 cents: > > > > But on reading Google's https://aip.dev/159 that now makes more sense, > > and that isn't what you were suggesting, but instaed a single, litteral > > `-` to mean "any dag id". Is this correct? > > > > That's also my under

Re: API spec questions

2020-05-12 Thread Kamil Breguła
GET /dags/DAG_A/dagRuns/2020-01-01/taskInstances GET /dags/DAG_A/dagRuns/2020-01-01/taskInstances On Tue, May 12, 2020 at 12:10 PM Ash Berlin-Taylor wrote: > > Hi Kamil, > > Thanks for re-opening this discussion! > > My initial complaint about "putting multiple values in a single path > element" i

Re: API spec questions

2020-05-12 Thread Jarek Potiuk
My 3 cents: > But on reading Google's https://aip.dev/159 that now makes more sense, > and that isn't what you were suggesting, but instaed a single, litteral > `-` to mean "any dag id". Is this correct? > That's also my understanding. > So I think then my only ask is that we have a `dag_ids`

Re: API spec questions

2020-05-12 Thread Ash Berlin-Taylor
Hi Kamil, Thanks for re-opening this discussion! My initial complaint about "putting multiple values in a single path element" is that it feels messy, and confusing, and very unlike any REST API I've consumed or written before. However I've just realised that I may have _wildy_ misunderstood the