Re: [DISCUSS] deprecate `days_ago` dates utility

2021-12-28 Thread Jarek Potiuk
I'd be for deprecating it. It's too easy to use with too much too loose and too little value. I see no real "business" value in it. On Tue, Dec 28, 2021 at 5:27 PM Daniel Standish wrote: > > Yeah that's correct. Sorry, I should have used `pendulum.today`. But yeah > also equivalent to `pendulu

Re: [DISCUSS] Stateless Hook approach (future direction?)

2021-12-28 Thread Jarek Potiuk
Anyone who was more involved in deferred operators ? On Tue, Dec 21, 2021 at 5:14 PM Jarek Potiuk wrote: > > Hey everyone, > > We had some discussions recently in Slack and GitHub Issues, about a > new approach that apparently we should take when it comes to hooks. > Seems that the "new" approach

Re: [DISCUSS] Installing Providers via Extras - Anitpattern?

2021-12-28 Thread Jarek Potiuk
Merry Xmas :) I have a warm feeling about keeping the providers as extras (but also I'd love to hear what others think). I only think we should change the extras to be "[providers.google], [providers.amazon], [providers.cncf.kubernetes] ... " to keep them easily separated from non-provider extras

Re: [DISCUSS] deprecate `days_ago` dates utility

2021-12-28 Thread Daniel Standish
Yeah that's correct. Sorry, I should have used `pendulum.today`. But yeah also equivalent to `pendulum.today('UTC').add(days=-N)` *(while `days_ago` uses timedelta it's the same when there's no DST is involved)* On Tue, Dec 28, 2021, 1:59 AM Ash Berlin-Taylor wrote: > days_ago is not just the

Re: [DISCUSS] deprecate `days_ago` dates utility

2021-12-28 Thread Ash Berlin-Taylor
days_ago is not just the same as utcnow minus N days, it is always "truncated" to the start of the day, so it's closer to "utcnow().replace(hour=0, minute=0, second=0) - timedelta(n)” On 28 December 2021 00:08:53 GMT, Daniel Standish wrote: >I recall some time ago we removed `days_ago` from a