Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Sumit Maheshwari
Yeah, make sense about updating the links. Once I move tests and docs one level up (prolly in the next client release) we will update the links again. On Thu, Jul 28, 2022 at 11:04 PM Jarek Potiuk wrote: > Yeah. Github API makes sense. > > Actually - I think we don't even have to move it, > I j

Re: [DISCUSS] consolidate dag scheduling params

2022-07-28 Thread Collin McNulty
I agree that the schedule params should be consolidated. I don't think it would be bad to coalesce around schedule_interval instead of making a new one. Cron expressions are already not really "intervals", and I think that asking the overwhelming majority of DAGs to change a param name is likely no

SparkSubmitHook - high memory consumption in YARN cluster mode

2022-07-28 Thread Tornike Gurgenidze
Hi all, I opened a ticket (https://github.com/apache/airflow/issues/24171) a while back and I just want to make sure that it got stale deservedly :) We used to have an issue with memory consumption on Airflow celery workers where tasks were often killed by OOM killer. Most of our workload was run

Re: [DISCUSS] consolidate dag scheduling params

2022-07-28 Thread Jarek Potiuk
+1 for new "schedule" param to rule them all and deprecate the rest. On Wed, Jul 27, 2022 at 10:36 PM Daniel Standish wrote: > As of airflow 2.3, we have two mutually-exclusive scheduling params, > `schedule_interval` and `timetable`. As it stands now, AIP-48 will be > adding a *third* such par

Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Jarek Potiuk
Yeah. Github API makes sense. Actually - I think we don't even have to move it, I just looked it up as I have not realised that the Docs are indexed and linked nicely already. hhttps:// github.com/apache/airflow-client-python/blob/master/airflow_client/README.md - so I think we just need to upda

Re: [VOTE] July 2022 PR of the Month

2022-07-28 Thread Jarek Potiuk
Sure. Experiments are cool. On Thu, Jul 28, 2022 at 7:12 PM Ross Turk wrote: > > Perhaps it doesn’t have to be something that only committers are > responsible for. If we use comments instead of tags, anyone can do it. > > We could a) add a bit of text underneath the PRotM section in the > newsl

Re: [VOTE] July 2022 PR of the Month

2022-07-28 Thread Ross Turk
Perhaps it doesn’t have to be something that only committers are responsible for. If we use comments instead of tags, anyone can do it. We could a) add a bit of text underneath the PRotM section in the newsletter that says something like “if you want to nominate a PR, flag it by adding #protm

Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Sumit Maheshwari
Thanks Jarek, Yeah, I don't think that any of the existing issues got fixed in this release. To fix these issues we prolly need to make changes to the main Airflow code base only, prolly only in the v1.yaml file.

Re: Wiki access please?

2022-07-28 Thread Jarek Potiuk
Anyone :) ? On Mon, Jul 18, 2022 at 10:38 AM Jarek Potiuk wrote: > I would love to hear what others think about the "in/out" approach - mine > is just the line of thoughts I've been exploring during the last few months > where I prepared my own line of thought about providers, maintenance, > inc

Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Jarek Potiuk
+1 (binding) I checked sources/signatures/checksums and runs the API calls using the https://github.com/apache/airflow-client-python/blob/master/dev/test_python_client.py against running Airflow 2.3.3 installation. However, when using the test client script, I have found that we still have the iss

Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Sumit Maheshwari
> > Nit though: we are shipping airflow_client/tests/ in the installed wheel > which we shouldn't do. (Since it's under airflow_client/ folder we don't > need to fix it now, but we should fix it before the next release please) Yeah, nice suggestion. We'll change the generator script to move out t

Re: [VOTE] Release Airflow Python Client 2.3.0 based on 2.3.0rc1

2022-07-28 Thread Ash Berlin-Taylor
+1 (binding) Nit though: we are shipping airflow_client/tests/ in the installed wheel which we shouldn't do. (Since it's under airflow_client/ folder we don't need to fix it now, but we should fix it before the next release please) -ash On Thu, Jul 28 2022 at 01:19:53 +05:30:00, Sumit Mahes