Re: [LAZY CONSENSUS] enable string normalization on black

+1 non-binding From: Felix Uellendall Sent: Wednesday, September 21, 2022 10:35 AM To: dev@airflow.apache.org Subject: RE: [EXTERNAL][LAZY CONSENSUS] enable string normalization on black CAUTION: This email originated from outside of the organization. Do not cl

Re: [DISCUSS] string normalization in black

+1 non-binding to starting the lazy consensus? :P From: Daniel Standish Sent: Wednesday, September 21, 2022 9:55 AM To: dev@airflow.apache.org Subject: RE: [EXTERNAL][DISCUSS] string normalization in black CAUTION: This email originated from outside of the org

Re: [LAZY CONSENSUS] enable string normalization on black

+1 (binding) As a double-quote guy I'm in favor, but having consistency is more important than my style preferences. Love it. On Wed, Sep 21, 2022 at 2:50 PM Drew Hubl wrote: > +1 (non-binding) > > On Sep 21, 2022, at 10:03 AM, Daniel Standish < > daniel.stand...@astronomer.io.INVALID> wrote: >

Re: [LAZY CONSENSUS] enable string normalization on black

+1 (non-binding) > On Sep 21, 2022, at 10:03 AM, Daniel Standish > wrote: > > Proposal: remove param --skip-string-normalization on black pre-commit hook > > Discussion thread: > https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n >

Re: [DISCUSS] AIP-50 Trigger DAG UI Extension with Flexible User Form Concept

Agree. That might be really nice to have it, and we could solve a long-standing issue with custom connection fields in the very same way. On Wed, Sep 21, 2022 at 8:27 PM Jeambrun Pierre wrote: > Loving Ash idea, param schema seems to have everything we need on top of > making this change much ea

Re: [DISCUSS] AIP-50 Trigger DAG UI Extension with Flexible User Form Concept

Loving Ash idea, param schema seems to have everything we need on top of making this change much easier to implement. Pierre Le mer. 21 sept. 2022 à 12:42, Ash Berlin-Taylor a écrit : > Hey Jens, > > Nice idea. I've left a comment on the AIP page, suggesting that we use the > existing DAG param

Re: [LAZY CONSENSUS] enable string normalization on black

+1 (binding) Best, Felix Sent from Proton Mail for iOS On Wed, Sep 21, 2022 at 19:10, Ash Berlin-Taylor wrote: > For clarity for those who didn't read the thread: > > This change will be applied just before 2.5 is going to be released (to avoid > making cherry picks difficult) > > -a > > On 2

Re: [LAZY CONSENSUS] enable string normalization on black

For clarity for those who didn't read the thread: This change will be applied just before 2.5 is going to be released (to avoid making cherry picks difficult) -a On 21 September 2022 18:03:19 BST, Daniel Standish wrote: >Proposal: remove param --skip-string-normalization on black pre-commit h

[LAZY CONSENSUS] enable string normalization on black

Proposal: remove param --skip-string-normalization on black pre-commit hook Discussion thread: https://lists.apache.org/thread/0g887n3gyr611k908zsz27ccshb85z2n After 72 hours, unless there is an objection, this proposal will be adopted. What is lazy consensus? Read here

Re: [DISCUSS] string normalization in black

> > Opinion: Adding a lazy consensus thread will not hurt and I think it > should happen Sure, can do >

Re: [DISCUSS] string normalization in black

Opinion: Adding a lazy consensus thread will not hurt and I think it should happen - for the record and for people who might be busy. I think it's easy to miss the fact that a decision was made in a [DISCUSS] thread. That's the main purpose of the subject prefixes - to drag attention for people w

Re: [DISCUSS] string normalization in black

+1 for string normalization. I love double quoted strings anyways :) On Wed, 21 Sep 2022 at 16:46, Daniel Standish wrote: > OK seems like all are in favor. Do we even need a vote? I guess lazy > consensus still applies even when you don't formally call for a lazy > consensus vote. So I recko

Re: [DISCUSS] string normalization in black

OK seems like all are in favor. Do we even need a vote? I guess lazy consensus still applies even when you don't formally call for a lazy consensus vote. So I reckon I won't bother. But the implementation to @Jed Cunningham 's point we can wait until closer to 2.5. And I'll connect with fo

Re: [DISCUSS] string normalization in black

> Happy to adapt to any style as long as I don't even have to think about it > and my personal preferences are not important here. That. On Sep 21 2022, at 12:45 pm, Jarek Potiuk wrote: > Yeah! Heated discussions! Tabs vs. Spaces. > > I am also full in for consistency. I think where there are no

Re: [DISCUSS] string normalization in black

Yeah! Heated discussions! Tabs vs. Spaces. I am also full in for consistency. I think where there are no clear arguments to do this or that, for me consistency trumps any individual preference/style (especially when it is backed with automation that will correct things for you and will not put any

Re: [ANNOUNCE] Apache Airflow 2.4.0 Released

Cool! On Wed, Sep 21, 2022 at 12:47 PM Alexander Shorin wrote: > Hi Jarek! > > The issue you referenced looks like exactly the one we faced. All the dags > we have had quite a history till 2016 year, so there are a lot of dag runs > for each of them. I'll post details there. > > Thank you for gu

Re: [ANNOUNCE] Apache Airflow 2.4.0 Released

Hi Jarek! The issue you referenced looks like exactly the one we faced. All the dags we have had quite a history till 2016 year, so there are a lot of dag runs for each of them. I'll post details there. Thank you for guidance! -- ,,,^..^,,, On Wed, Sep 21, 2022 at 1:28 PM Jarek Potiuk wrote:

Re: [DISCUSS] AIP-50 Trigger DAG UI Extension with Flexible User Form Concept

Hey Jens, Nice idea. I've left a comment on the AIP page, suggesting that we use the existing DAG param typying (which is built on top of JSON schema) -- to me it has a number of advtanges a) easier to secure (declarative, rather than executing code) which is a good goal as it means it can work

Re: [ANNOUNCE] Apache Airflow 2.4.0 Released

Hello Alexander, Can you please create an issue about it in Github and describe the circumstances of it with the details that will be enough for us to address it in 2.4.1. Thanks in advance, it can really help and is a small thing to ask in return for the great software you have for free. There i

Re: [DISCUSS] string normalization in black

The formatting discussions are always the most heated ones :) I'm for normalization - we have ugly mix of both and I'm down for whatever but to be consistent. I wouldn't worry about git history or cherry picks. We had several PRs recently that touched almost every file anyway (like improving our im