Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Elad Kalif
+1 (binding) On Sun, Dec 31, 2023 at 12:44 AM Hussein Awala wrote: > +1 (binding) I ran all the checks (signatures, licences, checksums, and > sources) and tested my changes; all looked good. > > On Sat, Dec 30, 2023 at 12:16 PM Phani Kumar > wrote: > > > +1 non binding > > > > On Sat, 30 Dec 2

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Hussein Awala
+1 (binding) I ran all the checks (signatures, licences, checksums, and sources) and tested my changes; all looked good. On Sat, Dec 30, 2023 at 12:16 PM Phani Kumar wrote: > +1 non binding > > On Sat, 30 Dec 2023, 16:10 Amogh Desai, wrote: > > > +1 non binding for providers apart from weavite

Airflow vs Temporal

2023-12-30 Thread Great Info
Hi All, In my current division already Temporal is being used for some onboarding workflow management, now there are a few data pipelines that will have few ETL jobs hence I am thinking of using Airflow to schedule ETL jobs and monitor. But to use airflow, it is required to provide a clear advantag

Re: [ANNOUNCE] Starting experimenting with "Require conversation resolution" setting

2023-12-30 Thread Jarek Potiuk
After an initial indentation problem in .asf.yaml it's not working as expected. So let's see how resolving conversations will work for us. On Sat, Dec 30, 2023 at 12:17 PM Amogh Desai wrote: > Wooho! Looking to see how this turns out for airflow 😃 > > On Sat, 30 Dec 2023 at 1:35 PM, Jarek P

Re: [ANNOUNCE] Starting experimenting with "Require conversation resolution" setting

2023-12-30 Thread Amogh Desai
Wooho! Looking to see how this turns out for airflow 😃 On Sat, 30 Dec 2023 at 1:35 PM, Jarek Potiuk wrote: > Hello everyone, > > As discussed in > https://lists.apache.org/thread/cs6mcvpn2lk9w2p4oz43t20z3fg5nl7l I just > enabled "require conversation resolution" for our main/stable branches. We

Re: [DISCUSSION] Enabling `pre-commit.ci` application for Airflow

2023-12-30 Thread Amogh Desai
I am aligning here with Pierre, but I am not against the idea of enabling the pre commit ci application. I’d rather have myself fix the issue as it sometimes also lets me have second,third or multiple passes at my code which is up for review. This is a personal choice where I feel that we are tryi

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Phani Kumar
+1 non binding On Sat, 30 Dec 2023, 16:10 Amogh Desai, wrote: > +1 non binding for providers apart from weavite > > Tested few dags around cncf provider mainly. Could not see any regressions. > > Thanks, > Amogh > > On Sat, 30 Dec 2023 at 4:08 PM, Pankaj Singh > wrote: > > > + 1 (non-binding) >

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Amogh Desai
+1 non binding for providers apart from weavite Tested few dags around cncf provider mainly. Could not see any regressions. Thanks, Amogh On Sat, 30 Dec 2023 at 4:08 PM, Pankaj Singh wrote: > + 1 (non-binding) > > On Sat, Dec 30, 2023 at 2:24 PM Wei Lee wrote: > > > +1 (non-binding) for provi

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Pankaj Singh
+ 1 (non-binding) On Sat, Dec 30, 2023 at 2:24 PM Wei Lee wrote: > +1 (non-binding) for providers other than Weavaite > > Tested our example DAGs with the following providers without encountering > issues > > apache-airflow-providers-amazon==8.15.0rc1 > apache-airflow-providers-cncf-kubernetes==

Re: [DISCUSSION] Enabling `pre-commit.ci` application for Airflow

2023-12-30 Thread Pierre Jeambrun
I like the idea, but in practice auto fixable static checks are very obvious to fix and doesn’t require much work. On the other hand most of static failure are ‘real issues’ and not auto fixable, for instance mypy, spelling, sphinx, db session usage etc…. (And ruff fix is a little aggressive IMO r

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Wei Lee
+1 (non-binding) for providers other than Weavaite Tested our example DAGs with the following providers without encountering issues apache-airflow-providers-amazon==8.15.0rc1 apache-airflow-providers-cncf-kubernetes==7.13.0rc1 apache-airflow-providers-google==10.13.1rc1 apache-airflow-providers-m

Re: [VOTE] Airflow Providers prepared on December 28, 2023

2023-12-30 Thread Jarek Potiuk
Need 2 binding (+1) to proceed on that one (and get RC2 for Waeviate) On Thu, Dec 28, 2023 at 6:48 PM Jarek Potiuk wrote: > We will get an rc2 for weaviate. Depending on how many other changes will > be merged in the meantime I will either release ad-hoc for just weaviate > (and potentially oth

Re: [DISCUSSION] Enabling `pre-commit.ci` application for Airflow

2023-12-30 Thread Scheffler Jens (XC-DX/PJ-PACE-E03)
I‘d also like to have auto-fixing included in CI. It is a classic pitfall and all that can be automated does not need to be a manual burden. Though I am not sure whether the plugin is able to use all the custom stuff as we also depend during execution on the CI image and docker. Besides security

[ANNOUNCE] Starting experimenting with "Require conversation resolution" setting

2023-12-30 Thread Jarek Potiuk
Hello everyone, As discussed in https://lists.apache.org/thread/cs6mcvpn2lk9w2p4oz43t20z3fg5nl7l I just enabled "require conversation resolution" for our main/stable branches. We have not used it in the past so it might not work as we think or we might need to tweak something. Generally speaking