Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Felix Uellendall
+1 Am 02/01/2019 um 22:52 schrieb Tao Feng: +1, but I think we still need the migration script for the change. On Wed, Jan 2, 2019 at 1:44 PM Bas Harenslak wrote: +1 On 2 Jan 2019, at 22:42, Daniel Imberman wrote: +1 On Wed, Jan 2, 2019 at 1:18 PM Maxime Beauchemin <

Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Tao Feng
+1, but I think we still need the migration script for the change. On Wed, Jan 2, 2019 at 1:44 PM Bas Harenslak wrote: > +1 > > > On 2 Jan 2019, at 22:42, Daniel Imberman > wrote: > > > > +1 > > > > On Wed, Jan 2, 2019 at 1:18 PM Maxime Beauchemin < > maximebeauche...@gmail.com> > > wrote: > >

Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Bas Harenslak
+1 > On 2 Jan 2019, at 22:42, Daniel Imberman wrote: > > +1 > > On Wed, Jan 2, 2019 at 1:18 PM Maxime Beauchemin > wrote: > >> +1 >> >> On Wed, Jan 2, 2019 at 1:00 PM Dan Davydov >> wrote: >> >>> +1 to removing >>> >>> On Wed, Jan 2, 2019 at 10:48 PM Driesprong, Fokko >>> wrote: >>>

Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Daniel Imberman
+1 On Wed, Jan 2, 2019 at 1:18 PM Maxime Beauchemin wrote: > +1 > > On Wed, Jan 2, 2019 at 1:00 PM Dan Davydov > wrote: > > > +1 to removing > > > > On Wed, Jan 2, 2019 at 10:48 PM Driesprong, Fokko > > wrote: > > > > > Hi all, > > > > > > Recently I've opened up a PR > > >

Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Maxime Beauchemin
+1 On Wed, Jan 2, 2019 at 1:00 PM Dan Davydov wrote: > +1 to removing > > On Wed, Jan 2, 2019 at 10:48 PM Driesprong, Fokko > wrote: > > > Hi all, > > > > Recently I've opened up a PR > > to remove the > > KnownEvent and KnownEventType

Re: [DISCUSS] Deprecate KnownEvent/KnownEventType

2019-01-02 Thread Dan Davydov
+1 to removing On Wed, Jan 2, 2019 at 10:48 PM Driesprong, Fokko wrote: > Hi all, > > Recently I've opened up a PR > to remove the > KnownEvent and KnownEventType for Apache Airflow 2.0. My feeling was that > not a lot of people are using