I agree with the other folks. I'm personally not a fan of pre commit hooks,
but if people like it, they can enable it.
Cheers, Fokko
Op di 23 jul. 2019 om 20:13 schreef Kaxil Naik
> It is fully-optional so I don't think we need an AIP there.
>
>
>
> On Tue, Jul 23, 2019 at 11:36 PM Beau Barker
It is fully-optional so I don't think we need an AIP there.
On Tue, Jul 23, 2019 at 11:36 PM Beau Barker
wrote:
> Just add a .pre-commit-config.yaml to the project, no need for an AIP.
>
> > On 24 Jul 2019, at 2:42 am, Jarek Potiuk
> wrote:
> >
> > Any more comments on it?
> > Should I make a
Just add a .pre-commit-config.yaml to the project, no need for an AIP.
> On 24 Jul 2019, at 2:42 am, Jarek Potiuk wrote:
>
> Any more comments on it?
> Should I make an AIP for that :)? Or should I just ask a vote/propose a PR
> ? Anyone has a strong opinion?
> I think it changes the dev workfl
Any more comments on it?
Should I make an AIP for that :)? Or should I just ask a vote/propose a PR
? Anyone has a strong opinion?
I think it changes the dev workflow quite a bit on one hand, but it is
fully optional on the other hand.
On Thu, Jul 4, 2019 at 9:23 AM Kamil Breguła
wrote:
> +1 At
+1 At first I was skeptical about this tool. I prefer to run it by
hand, but I am more and more convinced that using it as a pre-commit
makes sense.
On Wed, Jul 3, 2019 at 10:58 PM Felix Uellendall wrote:
>
> +1 (non-binding), I love that. I use a git pre-commit bash script but I think
> the fra
+1 (non-binding), I love that. I use a git pre-commit bash script but I think
the framework looks even better. :)
-feluelle
Original Message
On Jul 2, 2019, 19:48, Maxime Beauchemin wrote:
> +1
>
> On Mon, Jul 1, [2019](tel:2019) at 11:20 PM Kaxil Naik
> wrote:
>
>> +1 We ha
+1
On Mon, Jul 1, 2019 at 11:20 PM Kaxil Naik wrote:
> +1 We have been using this on some of our Astronomer repositories as well
> and have been happy with it.
>
> Regards,
> Kaxil
>
> On Tue, Jul 2, 2019, 11:46 Jarek Potiuk wrote:
>
> > TL;DR: I would like to make a proposal to add (easily ma
+1 We have been using this on some of our Astronomer repositories as well
and have been happy with it.
Regards,
Kaxil
On Tue, Jul 2, 2019, 11:46 Jarek Potiuk wrote:
> TL;DR: I would like to make a proposal to add (easily managed) pre-commit
> hooks with various lint checkers part of recommende
TL;DR: I would like to make a proposal to add (easily managed) pre-commit
hooks with various lint checkers part of recommended (and encouraged)
development workflow for Airflow. This will help with speeding-up local
development cycle and decrease pressure on Travis CI.
Over the last few months in
