+1 given it is a time based release.
On Tue, Jan 22, 2019 at 7:00 AM Ash Berlin-Taylor wrote:
> +1 (binding)
>
> - Checksums match
> - Signing good
> - version.py doesn't contain "rc"
> - UPDATING.md looks good
> - Tested celery executor on redis.
> - Pausing/unpausing dags on RBAC UI
> - Impor
+1 (binding)
- Checksums match
- Signing good
- version.py doesn't contain "rc"
- UPDATING.md looks good
- Tested celery executor on redis.
- Pausing/unpausing dags on RBAC UI
- Import errors from dags showing up in RBAC UI.
I did notice something in the task instance logs that I want to look at,
Can I suggest that we get in the habit of time based releases, now that we
don’t have to vote twice? In this context I suggest that not having
documentation is not blocking for release, but that we should do a quick .3
release
Tao can you change your vote to +1?
Verstuurd vanaf mijn iPad
> Op
+1 (non-binding)
I could not found any more blocker issues. I ran all example dags and
some of our own dags via RBAC UI.
- feluelle
Am 19/01/2019 um 17:35 schrieb Kaxil Naik:
Hey all,
I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
which will last for 72 hours. C
My vote is changed to 0 for this RC. I have prepared a pr to fix the viewer
issue(https://github.com/apache/airflow/pull/4569). @Deng Xiaodong
could you test the pr and see if the issue
still exists?
On Mon, Jan 21, 2019 at 11:05 AM Kaxil Naik wrote:
> @FengTao
>
> Do you have a "-1" vote or
@FengTao
Do you have a "-1" vote or "+1" vote?
On Mon, Jan 21, 2019, 18:21 Tao Feng Create a jira for the viewer bug(
> https://issues.apache.org/jira/browse/AIRFLOW-3745).
>
> On Mon, Jan 21, 2019 at 9:12 AM Deng Xiaodong wrote:
>
>> Hi Kaxil,
>>
>>
>> After double-checking, I believe the View
Create a jira for the viewer bug(
https://issues.apache.org/jira/browse/AIRFLOW-3745).
On Mon, Jan 21, 2019 at 9:12 AM Deng Xiaodong wrote:
> Hi Kaxil,
>
>
> After double-checking, I believe the Viewer access/permission issue is not
> a bug actually. Seems it's because the DAG-level access contr
Hi Kaxil,
After double-checking, I believe the Viewer access/permission issue is not
a bug actually. Seems it's because the DAG-level access control feature is
cherry-picked into 1.10.2rc3.
But my understanding is this feature is still under development? @feng-tao
kindly advise.
On the other
+1 (non-binding)
but it should be noted you have to run airflow initdb to get the super role
added; i keep forgetting to do that.
Cheers,
Josh
PXYData
On 2019/01/21 09:53:15, Naik Kaxil wrote:
> Hi XD,
>
> I could not replicate that in non-rbac UI but could replicate it on RBAC one.
>
> Pl
Yea this worked for me. I forgot you have to airflow initdb to create the
superuser field, may want to note that in the docs somewhere.
Cheers,
Josh
PXYData
On 2019/01/19 16:35:49, Kaxil Naik wrote:
> Hey all,>
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
release,>
> wh
Hi XD,
I could not replicate that in non-rbac UI but could replicate it on RBAC one.
Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC
(Flask-Admin UI)
All the below issues don't seem to be a blocker for this release, however I am
open to views from all.
(1) Errors not sh
Hi XD,
I will test this and let you know.
One more bug cropped up https://issues.apache.org/jira/browse/AIRFLOW-3737 .
@fokko or someone with more K8s experience can have a look at it, please?
Regards,
Kaxil
On 21/01/2019, 09:05, "Deng Xiaodong" wrote:
Hi Kaxil,
I found anothe
Hi Kaxil,
I found another potential bug which is applicable for both RBAC and
non-RBAC UI:
Let’s say we’re trying to import a module which doesn’t exist at all, or
have any syntax error in the DAG, the DAG will not be parsed. In addition,
In earlier version, there will be a warning message appear
Hi Feng Tao,
As mentioned in my previous email to XD, as this is not a BLOCKER and the
fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
And we can fix that in the upcoming release with other fixes which should
be quick and aim to release that in a month as well?
RBAC is
Hi XD,
Even if this issue exist, it should!'t block the release. As mentioned by
Seelman, you can apply that fix. Remember RBAC is still not a default UI
for this release.
We should aim to have regular releases to fix this kinds of issues. As this
is not blocking and the fix exists, can you chang
Thanks XD and Stefan. I see the issue now. I agree that this should be a
bug which should be fixed. Please remove my +1 vote for release if
possible.
On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong wrote:
> Hi Feng Tao,
>
> I tried again by deleting the DB and initdb again, the issue is still
>
Hi Feng Tao,
I tried again by deleting the DB and initdb again, the issue is still there.
Please note the issue is not “see all the roles”. The issue is after
logging in as a Viewer role, I can’t access the pages including Tree View,
Graph View, Task Duration, Gantt, Code View, etc.
XD
On Mon,
I was able to reproduce, to fix I modified the "Viewer" role via the UI
and added permission "can dag read on all_dags" manually.
On 1/21/19 6:49 AM, Deng Xiaodong wrote:
> Hi Kaxil,
>
> A potential bug found in 1.10.2rc3.
>
>
> # Potential Bug:
>
> Viewer Role can't access pages to which it
+1 (binding)
I install the rc3 locally and create a new role and could view it in UI
without issues.
On Sat, Jan 19, 2019 at 8:36 AM Kaxil Naik wrote:
> Hey all,
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (bin
Hi Xiaodong,
I just tried with a viewer role which can't reproduce your issue. I could
see all the roles without any issues. Have you reset your db with this rc?
On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong wrote:
> Hi Kaxil,
>
> A potential bug found in 1.10.2rc3.
>
>
> # Potential Bug:
>
> V
Hi Kaxil,
A potential bug found in 1.10.2rc3.
# Potential Bug:
Viewer Role can't access pages to which it has permissions
# How to Reproduce:
- Under RBAC UI, create a user with "Viewer" role. Then use this
account to log in.
- You will be able to access the main page. However, you will not b
You won't need to build assets. When we release (create tar file), the
assets are compiled using node and are already included. Hence, you would
just need to do `pip install apache-airflow==1.10.2rc3`
Regards,
Kaxil
On Sun, Jan 20, 2019, 21:53 Stefan Seelmann +1 (non-binding)
>
> Deployed in our
@seelman, sorry my bad - I didn't read that you build it from source. :-)
Yes, you would need to build it using nom if you build it from source.
Regards,
Kaxil
On Sun, Jan 20, 2019, 22:22 Kaxil Naik You won't need to build assets. When we release (create tar file), the
> assets are compiled usin
+1 (non-binding)
Deployed in our test env and run the test suite.
The update from 1.10.0 to 1.10.2rc3 was a bit bumpy:
* DAG level access was only added in 1.10.2, not already in 1.10 as
described in `UPDATING.md`. We use functions from `www_rbac/security.py`
to create custom roles, but the file
+1, binding
Checked:
* KEYS
* Signatures
* Git Tag
Bolke
> On 19 Jan 2019, at 17:35, Kaxil Naik wrote:
>
> Hey all,
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
>
> Airflow 1.10.2 RC3 is availa
Hey all,
I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
which will last for 72 hours. Consider this my (binding) +1.
Airflow 1.10.2 RC3 is available at:
https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
*apache-airflow-1.10.2rc3-source.tar.gz* is a source rel
26 matches
Mail list logo
