Cancelled [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-08-01 Thread Ash Berlin-Taylor
RC5 coming shortly. -ash > On 1 Aug 2019, at 13:07, Ash Berlin-Taylor wrote: > > Oh it wasn't a bad cherry-pick but a "merge fight" - you added a call to > _manager.shutdown but I removed manager. The problem is on master too > https://github.com/apache/airflow/blob/bfff185edbc1b27a635d613b

Re: [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-08-01 Thread Ash Berlin-Taylor
Oh it wasn't a bad cherry-pick but a "merge fight" - you added a call to _manager.shutdown but I removed manager. The problem is on master too https://github.com/apache/airflow/blob/bfff185edbc1b27a635d613beecf80fe1dbd3758/airflow/jobs/scheduler_job.py#L188

Re: [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-08-01 Thread Dan Davydov
Haven't taken a look at the bad cherry pick, but if it's my fault LMK will take a look and submit a patch (I'll be out after tomorrow though). On Thu, Aug 1, 2019 at 2:53 PM Ash Berlin-Taylor wrote: > We've just noticed two problems: > > 1. If a dag parser process takes too long the DagFIleProce

[VOTE] Release Apache Airflow 1.10.4 from RC4

2019-08-01 Thread Ash Berlin-Taylor
We've just noticed two problems: 1. If a dag parser process takes too long the DagFIleProcessorManager dies with an exception when trying to kill it (A bad cherry-pick between #5615 and #5605) The logs when this happens are: [2019-08-01 12:48:13,524] {dag_processing.py:543} INFO - Launched Dag

Re: [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-07-31 Thread Kaxil Naik
Thank You Ash & Jarek, well done. Will test the RCs on Friday after reaching UK. On Wed, Jul 31, 2019, 15:55 Ash Berlin-Taylor wrote: > And a shout-out to Jarek for his help with this release - both with his > work on speeding up the CI pipeline as much as we can on Travis, and with > some of t

Re: [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-07-31 Thread Ash Berlin-Taylor
And a shout-out to Jarek for his help with this release - both with his work on speeding up the CI pipeline as much as we can on Travis, and with some of the cherry-picking! -a > On 31 Jul 2019, at 11:07, Jarek Potiuk wrote: > > 💟 > > On Wed, Jul 31, 2019 at 12:03 PM Ash Berlin-Taylor wrote

Re: [VOTE] Release Apache Airflow 1.10.4 from RC4

2019-07-31 Thread Jarek Potiuk
💟 On Wed, Jul 31, 2019 at 12:03 PM Ash Berlin-Taylor wrote: > Hi my fellow Airflow peeps, > > After the process leaking bug James found and the Mysql 8.0.16+ issue > Jarek reported (both of which have been fixed) we are now ready to try > again. I have just cut 1.10.4rc4. > > This email is calli

[VOTE] Release Apache Airflow 1.10.4 from RC4

2019-07-31 Thread Ash Berlin-Taylor
Hi my fellow Airflow peeps, After the process leaking bug James found and the Mysql 8.0.16+ issue Jarek reported (both of which have been fixed) we are now ready to try again. I have just cut 1.10.4rc4. This email is calling a vote on the release, which will last for 72 hours (2019-08-03 10:00