Re: Enable LGTM on the repository

2019-08-20 Thread Jarek Potiuk
+1 ! Fantastic! It will be great to see our code improves as we are progressing with Pylint fixes + maybe it can motivate us to finally implement better strategy for keeping pip dependencies up-to-date. I also think Javascript is also important. I wonder how our score might improve if we decide

Re: Enable LGTM on the repository

2019-08-20 Thread Kaxil Naik
The tool looks good. It also shows when this error was introduced and more debug information. [image: image.png] +1 from my side to integrate it On Tue, Aug 20, 2019 at 11:49 AM Ash Berlin-Taylor wrote: > Interesting! > > One or two of the rules we'd probably want to ignore (`Module 'airflow'

Re: Enable LGTM on the repository

2019-08-20 Thread Ash Berlin-Taylor
Interesting! One or two of the rules we'd probably want to ignore (`Module 'airflow' is imported with both 'import' and 'import from'`) and possibly the cycle one, but some of them certainly look like bugs/errors that should be fixed. > On 20 Aug 2019, at 10:00, Driesprong, Fokko wrote: > >

Enable LGTM on the repository

2019-08-20 Thread Driesprong, Fokko
Hi all, I recently bumped into LGTM , an automated vulnerability checker. Besides that, it also analyzes general code quality. I think it would be nice to enable this on Airflow as well. LGTM automatically runs 1600+ standard analyses contributed by