in a
> finally statement shouldn't be written so it can cause harm on exiting.
>
> Damian
>
>
> -Original Message-----
> From: Alex Guziel [mailto:alex.guz...@airbnb.com.INVALID]
> Sent: Wednesday, October 02, 2019 4:03 PM
> To: dev@airflow.apache.org
> Sub
n to poor python code and case 2) any code in a finally
statement shouldn't be written so it can cause harm on exiting.
Damian
-Original Message-
From: Alex Guziel [mailto:alex.guz...@airbnb.com.INVALID]
Sent: Wednesday, October 02, 2019 4:03 PM
To: dev@airflow.apache.org
Subj
Task_copy.on_kill() should probably be killing the underlying process, but
I think it's fuzzy where the exception gets thrown. I think the intention
is for the exception to get caught in that same block, so the cleanup can
happen, but this is not the case since it is thrown in the main thread. I
th
Actually, reading the docs, the handler throws it in the main thread. In
that case we should definitely change it to subclass SystemExit, or just
use System.exit
On Wed, Oct 2, 2019 at 12:53 PM Alex Guziel wrote:
> It's been a while since I've looked at this code, but the exception thrown
> ther
It's been a while since I've looked at this code, but the exception thrown
there is thrown from a place where it should not be able to be caught by
your operator code, so the issue may be somewhere else.
On Wed, Oct 2, 2019 at 12:41 PM Shaw, Damian P. <
damian.sha...@credit-suisse.com> wrote:
> T
Today I had an issue where my operator caught the SIGTERM exception that
Airflow throws. It seems to me that Airflow shouldn't be throwing a SIGTERM
exception that subclasses Exception, particular as in arbitrary Python
functions this might happen commonly.
The code in my operator looked like t
