+1 on my end!
via Newton Mail
[https://cloudmagic.com/k/d/mailapp?ct=dx=10.0.50=10.15.6=email_footer_2]
On Wed, Sep 9, 2020 at 7:38 PM, Maxime Beauchemin
wrote:
+1
On Wed, Sep 9, 2020 at 10:36 AM Vikram Koka wrote:
> +1 on absolute import. Honestly, a huge fan of doing it as an absolute
+1
On Wed, Sep 9, 2020 at 10:36 AM Vikram Koka wrote:
> +1 on absolute import. Honestly, a huge fan of doing it as an absolute vs.
> relative.
>
> On Wed, Sep 9, 2020 at 4:09 AM Kaxil Naik wrote:
>
> > No strong opinion but absolute import seems better from a user's
> > perspective.
> >
> > On
+1 on absolute import. Honestly, a huge fan of doing it as an absolute vs.
relative.
On Wed, Sep 9, 2020 at 4:09 AM Kaxil Naik wrote:
> No strong opinion but absolute import seems better from a user's
> perspective.
>
> On Wed, Sep 9, 2020 at 12:07 PM Jarek Potiuk
> wrote:
>
> > +1!
> >
> > On
No strong opinion but absolute import seems better from a user's
perspective.
On Wed, Sep 9, 2020 at 12:07 PM Jarek Potiuk
wrote:
> +1!
>
> On Wed, Sep 9, 2020 at 11:11 AM Ash Berlin-Taylor wrote:
>
> > Get's my vote, certainly.
> >
> > Here's a PR to do it --
+1!
On Wed, Sep 9, 2020 at 11:11 AM Ash Berlin-Taylor wrote:
> Get's my vote, certainly.
>
> Here's a PR to do it -- https://github.com/apache/airflow/pull/10825
>
> If no one complains in 24 hours lets merge that.
>
> On Sep 9 2020, at 9:35 am, Tomasz Urbaszek
> wrote:
>
> > Hi all,
> >
> > I
Get's my vote, certainly.
Here's a PR to do it -- https://github.com/apache/airflow/pull/10825
If no one complains in 24 hours lets merge that.
On Sep 9 2020, at 9:35 am, Tomasz Urbaszek wrote:
> Hi all,
>
> I would like to spark a (hopefully short) discussion about import
> style in
Hi all,
I would like to spark a (hopefully short) discussion about import
style in Airflow. In short: absolute vs relative imports.
Reason for this discussion:
https://github.com/apache/airflow/pull/10729#discussion_r485419342
Personally I think we should enforce (using pre-commit hook) absolute
