Re: Latest Sphinx (2.1.2) causes master to fail

Oh nice, I had never looked into poetry before. I might just use that on the Superset side too then! Max On Mon, Jun 24, 2019 at 2:31 PM Jarek Potiuk wrote: > Indeed. Poetry is what we wanted to try already for quite a while and it > seems it has pretty much what we need including extras

Re: Latest Sphinx (2.1.2) causes master to fail

Indeed. Poetry is what we wanted to try already for quite a while and it seems it has pretty much what we need including extras support and .lock file - quite similar to npm approach + nice set of command line tools to manage deps. J. On Mon, Jun 24, 2019 at 11:24 PM Ash Berlin-Taylor wrote: >

Re: Latest Sphinx (2.1.2) causes master to fail

Hi Max, Did you take a look at Poetry (https://poetry.eustace.io/ )? How does this PR compare? -ash > On 24 Jun 2019, at 22:02, Maxime Beauchemin > wrote: > > This Superset PR may be relevant and useful for Airflow too (still WiP): >

Re: Latest Sphinx (2.1.2) causes master to fail

This Superset PR may be relevant and useful for Airflow too (still WiP): https://github.com/apache/incubator-superset/pull/7762 Basically it allows your project to define a "requirements/" folder with a "requirements.json" as a single source of truth for all deps, including the details of what

Re: Latest Sphinx (2.1.2) causes master to fail

It works :) - The CI passed for the commit on v1-10-test, so your PR should pass as well. On Mon, Jun 24, 2019 at 1:40 PM Jarek Potiuk wrote: > I pinned auto-api to below 1.1.0 and re-run the test - Let's hope it works > for now . > > On Mon, Jun 24, 2019 at 10:05 AM Jarek Potiuk > wrote: > >

Re: Latest Sphinx (2.1.2) causes master to fail

I pinned auto-api to below 1.1.0 and re-run the test - Let's hope it works for now . On Mon, Jun 24, 2019 at 10:05 AM Jarek Potiuk wrote: > OK. After some checks it turns out it's not only Sphinx really but also > sphinx-autoapi (v 1.1.0 released yesterday). > > J. > > > On Mon, Jun 24, 2019 at

Re: Latest Sphinx (2.1.2) causes master to fail

Yeah, I was discussing that with Ash and just posted the same message :-D On Mon, Jun 24, 2019 at 1:35 PM Jarek Potiuk wrote: > OK. After some checks it turns out it's not only Sphinx really but also > sphinx-autoapi (v 1.1.0 released yesterday). > > J. > > > On Mon, Jun 24, 2019 at 9:29 AM

Re: Latest Sphinx (2.1.2) causes master to fail

It is actually Sphinx AutoApi - I am testing it now on v1-1-test branch by pinning the older version. Will keep you posted. On Mon, Jun 24, 2019 at 12:59 PM Jarek Potiuk wrote: > Kamil prepared a fix https://github.com/apache/airflow/pull/5468 > (thanks!) and > when I tested it on a clean

Re: Latest Sphinx (2.1.2) causes master to fail

OK. After some checks it turns out it's not only Sphinx really but also sphinx-autoapi (v 1.1.0 released yesterday). J. On Mon, Jun 24, 2019 at 9:29 AM Jarek Potiuk wrote: > Kamil prepared a fix https://github.com/apache/airflow/pull/5468 (thanks!) and > when I tested it on a clean

Re: Latest Sphinx (2.1.2) causes master to fail

Kamil prepared a fix https://github.com/apache/airflow/pull/5468 (thanks!) and when I tested it on a clean pip-install with latest sphinx it seems to work fine (Running Travis CI build now). Let's see if it helps. BTW. The AIP-10 Docker image

Re: Latest Sphinx (2.1.2) causes master to fail

Any cyclic imports we have aren't actually a problem and are handled fine by python 3 (obviously, else it wouldn't work) so I think this is a big in sphinx with it being over zealous. This only affects tests and development, not our users in this case. If it's difficult to fix I would go with

Re: Latest Sphinx (2.1.2) causes master to fail

@Ash Berlin-Taylor ? On Mon, Jun 24, 2019 at 1:37 AM Jarek Potiuk wrote: > Hello Everyone, > > We have yet another case where relesing a package (Sphinx 2.1.2 in this > case) - started to cause master to fail. > > Should we pin Sphinx to an earlier version or maybe someone can help and >

Latest Sphinx (2.1.2) causes master to fail

Hello Everyone, We have yet another case where relesing a package (Sphinx 2.1.2 in this case) - started to cause master to fail. Should we pin Sphinx to an earlier version or maybe someone can help and figure out and fix it quickly (seems that there are some cyclic imports that probably need