Re: Re: [DISCUSS] Sensor Improvements With Tirggers

2024-10-07 Thread Pavankumar Gopidesu
w/providers/microsoft/azure/sensors/msgraph.py > > > > > > The idea was the same as in your proposition to not block workers when > > > using a sensor by implementing it as a deferrable. > > > > > > Kind regards, > > > David > &g

Re: Re: [DISCUSS] Sensor Improvements With Tirggers

2024-10-03 Thread Alex Guglielmone
> > > > > > You can check here how I did it: > > > >https://github.com/apache/airflow/blob/main/airflow/providers/microsoft/azure/sensors/msgraph.py > > > > > > The idea was the same as in your proposition to not block workers when > > > using a sensor

Re: Re: [DISCUSS] Sensor Improvements With Tirggers

2024-10-02 Thread Alex
he idea was the same as in your proposition to not block workers when > > using a sensor by implementing it as a deferrable. > > > > Kind regards, > > David > > > > -Original Message- > > From: Pavankumar Gopidesu > > Sent: Thursday, Septemb

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-09-27 Thread Pavankumar Gopidesu
rkers when > using a sensor by implementing it as a deferrable. > > Kind regards, > David > > -Original Message- > From: Pavankumar Gopidesu > Sent: Thursday, September 26, 2024 11:01 AM > To: dev@airflow.apache.org > Subject: Re: [DISCUSS] Sensor Improvement

RE: [DISCUSS] Sensor Improvements With Tirggers

2024-09-26 Thread Blain David
Subject: Re: [DISCUSS] Sensor Improvements With Tirggers EXTERNAL MAIL: Indien je de afzender van deze e-mail niet kent en deze niet vertrouwt, klik niet op een link of open geen bijlages. Bij twijfel, stuur deze e-mail als bijlage naar ab...@infrabel.be<mailto:ab...@infrabel.be>. Hello Ev

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-09-26 Thread Pavankumar Gopidesu
Hello Everyone, After discussion on the slack channel, I have decided to retain the current synchronous sensor to offer users the choice to execute sensors on workers. I have revised the proposal to introduce a new asynchronous version of the sensor, eliminating the need for workers to run sensors

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-08-14 Thread Pavankumar Gopidesu
Hi Wei Lee, Thanks for the review, While I was working on the POC , I had a bit of confusion about how to use the logic present inside the sensor execute method. for both with and without triggerer flow. so to make it work for both flows, I have moved out to execute logic with two methods. I appr

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-08-14 Thread Wei Lee
Thank you for bringing this up! I have added some comments to the document. I'm unsure if we really want or need to implement more complex logic for this. What I have in mind is simply adding helper functions to InternalSensorTrigger and continuing to use the run method in BaseTrigger. The main

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-08-14 Thread Pavankumar Gopidesu
Hi Jarek, Thanks for the questions :) , I completely agree with you , from 2.10 we have the start_from_trigger parameter, which , when set , allows a task to be executed directly from the triggerrer without worker involvement. I believe that for any sensor to be executed in the triggerer, a corre

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-08-13 Thread Jarek Potiuk
How does it differ from the upcoming 2.10 feature? * Deferrable operators can now execute directly from the triggerer without needing to go through the worker. This is especially efficient for certain operators, like sensors, and can help teams save both time and money. As of 2.10 - Sensors alrea

Re: [DISCUSS] Sensor Improvements With Tirggers

2024-08-11 Thread Kaxil Naik
Thanks for putting this together, I will take a look this week. On Fri, 9 Aug 2024 at 13:12, Pavankumar Gopidesu wrote: > Hi All, > > I have created a draft document for Sensor Improvements using triggers. > > Details: > > https://docs.google.com/document/d/1Kb_wL-T1DHkOpmR_QNa3O5p_2hMTLzM-sb_Hz