wish to run every 24 hours that starts in a specific time or timezone then
timedelta(days=1) makes sense.
Regards
Damian
-Original Message-
From: Bolke de Bruin [mailto:bdbr...@gmail.com]
Sent: Tuesday, May 14, 2019 2:13 AM
To: dev@airflow.apache.org
Subject: Re: Cron schedule with DST
The idea is obviously that with a Timedelta you want to say "add 24h". With DST
this shifts the actual point in local time (in local time 17.00 can become
16.00/18.00).
Cron schedules specify points in local time so 17.00h always stays 17.00h.
There is nothing to make configurable here. Otherw
The distinction could come from being non-UTC VS UTC. You can schedule a
DAG at any time UTC and it would follow the 24-hour intervals but if it is
non-UTC it would follow DST changes when relevant (by timezone). You could
technically make this behavior configurable and follow the former path as
Just to add to that: there are already tests that tests this behaviour:
https://github.com/PolideaInternal/airflow/blob/master/tests/models/test_dag.py#L749
and
indeed - the schedule follows DST changes rather than discards the DST time.
I think it is generally a good idea to follow DST (for clari
It would be great if people can provide failing unit tests as PR with clear
expectations stated out as code. It makes it easier for people to get
consensus on expectations and for anyone to jump in and implement a fix.
Max
On Mon, May 13, 2019 at 12:48 PM David Klosowski
wrote:
> Damian is corr
Damian is correct. We've observed that exact behavior and noticed the
timedelta logic is dubiously broken for DST but works for CRON.
On Mon, May 13, 2019 at 12:38 PM Shaw, Damian P. <
damian.sha...@credit-suisse.com> wrote:
> Hi,
>
> I’m not part of the Airflow team but I came to the same concl
It is assumed that you want to have cron always at the exact *local time*.
So in your case always 17.00h. I see that indeed the documentation is not
correct here. It actually observes DST.
Cheers
Bolke
On 13 May 2019 at 21:38:04, Shaw, Damian P. (damian.sha...@credit-suisse.com)
wrote:
Hi,
I’m
Hi,
I’m not part of the Airflow team but I came to the same conclusion, that the
behavior is the opposite of what the documentation specifies. When using the
cron notation then DST is properly honored, when using timedelta it is not. I
played around with the DAG.following_schedule method to sat
