Re: Reverting [AIRFLOW-1467] Dynamic pooling

Thanks for contributing it Bin! śr., 22 sty 2020, 07:03 użytkownik Xinbin Huang napisał: > Just an update to this. The feature has been added to the master branch > using the BoringCyborg. Hopefully, we can say goodbye to multiple migration > heads from now on. > > Thanks @kaxil @jarek for the

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Just an update to this. The feature has been added to the master branch using the BoringCyborg. Hopefully, we can say goodbye to multiple migration heads from now on. Thanks @kaxil @jarek for the help during the process! Bin On Tue, Jan 14, 2020 at 12:29 PM Jarek Potiuk wrote: > Few more hint

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Few more hints: - example how to see if any file in "airflow/migrations" folder has been modified - you can see how Kaxil implemented labeler.js. - I believe in order to check if the PR needs rebase you need to check if the first (or last?) commit in the PR has parent = current master

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Cool! - Fork Kaxil's boring-cyborg: https://github.com/kaxil/boring-cyborg - you will create PRs from there - Setup environment. It's easy and fairly self-detected if you use IntelliJ or VSCode. Even if not, it boils down to running `npm install`. - run 'npm run dev'. It will run t

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Hi Jarek, I would like to take a try into this. Where should I get started? Thanks Bin On Tue, Jan 14, 2020 at 1:28 AM Jarek Potiuk wrote: > Absolutely - it's great that we have the checks in master :). > > But I am thinking about some solutions already. We actually can do > something using Ka

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Absolutely - it's great that we have the checks in master :). But I am thinking about some solutions already. We actually can do something using Kaxil's probot. While preventing merges for all PRs that have not been rebased to latest master is quite an overkill, but I think we can prevent merging

Re: Reverting [AIRFLOW-1467] Dynamic pooling

Hi Jarek, Hopefully, this doesn't happen too often since the tables should be slowly changing. The solution here is to ask the contributors to rebase their PR more often. I'm happy that this is being caught now, and we don't have multiple heads as before :-) Cheers, Fokko Op ma 13 jan. 2020 om

Re: Reverting [AIRFLOW-1467] Dynamic pooling

BTW. We'll have to find a better solution to prevent it as it has happened in the past. I will think about it :). Any ideas are welcome :). On Mon, Jan 13, 2020 at 10:21 PM Jarek Potiuk wrote: > Hello everyone, > > Without asking I quickly reverted the > https://github.com/apache/airflow/pull/69

Reverting [AIRFLOW-1467] Dynamic pooling

Hello everyone, Without asking I quickly reverted the https://github.com/apache/airflow/pull/6975 ([AIRFLOW-1467 ] Dynamic pooling via allowing tasks to use more than one pool slot (depending upon the need)) as it had duplicated heads in sqlite m