Re: Use -x when cherry-picking to v1-10 branches

2019-04-30 Thread Driesprong, Fokko
Good point Jarek, thanks for brining this up! Cheers, Fokko Op di 23 apr. 2019 om 01:23 schreef Deng Xiaodong : > Agree. > > XD > > On Tue, Apr 23, 2019 at 05:15 Kaxil Naik wrote: > > > Definitely, agreed. > > > > On Mon, Apr 22, 2019 at 9:28 PM Jarek Potiuk > > wrote: > > > > > Hello Everyone

Re: Use -x when cherry-picking to v1-10 branches

2019-04-22 Thread Deng Xiaodong
Agree. XD On Tue, Apr 23, 2019 at 05:15 Kaxil Naik wrote: > Definitely, agreed. > > On Mon, Apr 22, 2019 at 9:28 PM Jarek Potiuk > wrote: > > > Hello Everyone (committers especially). > > > > I have a proposal to improve slightly the cherry-picking process between > > master and v1-10-branches

Re: Use -x when cherry-picking to v1-10 branches

2019-04-22 Thread Kaxil Naik
Definitely, agreed. On Mon, Apr 22, 2019 at 9:28 PM Jarek Potiuk wrote: > Hello Everyone (committers especially). > > I have a proposal to improve slightly the cherry-picking process between > master and v1-10-branches: We could use `-x` flag when cherry-picking. This > will automatically record

Re: Use -x when cherry-picking to v1-10 branches

2019-04-22 Thread Maxime Beauchemin
Always, always use `-x` when cherry-picking! On Mon, Apr 22, 2019 at 1:28 PM Jarek Potiuk wrote: > Hello Everyone (committers especially). > > I have a proposal to improve slightly the cherry-picking process between > master and v1-10-branches: We could use `-x` flag when cherry-picking. This >

Use -x when cherry-picking to v1-10 branches

2019-04-22 Thread Jarek Potiuk
Hello Everyone (committers especially). I have a proposal to improve slightly the cherry-picking process between master and v1-10-branches: We could use `-x` flag when cherry-picking. This will automatically record the original commit hash. Can we agree on that between committers :)? J. Here is