Re: Close SqlSensor Connection

2018-01-16 Thread Alexis Rolland
Ok indeed I can see the connection is getting closed in get_records! Thanks Alexis Rolland +86 138 1602 1449 > Le 17 janv. 2018 à 03:18, Bolke de Bruin a écrit : > > Good point Chris. I overlooked that. > > B. > >> On 16 Jan 2018, at 20:09, Chris Palmer

Re: Close SqlSensor Connection

2018-01-16 Thread Bolke de Bruin
Good point Chris. I overlooked that. B. > On 16 Jan 2018, at 20:09, Chris Palmer wrote: > > I'm not sure this is the right solution. I haven't explored all the code > but it seems to me that the actual database connections are managed in the > hooks. Different databases

Re: Close SqlSensor Connection

2018-01-16 Thread Chris Palmer
I'm not sure this is the right solution. I haven't explored all the code but it seems to me that the actual database connections are managed in the hooks. Different databases will want to handle this differently, and modifying SqlSensor seems too heavy handed to me. If you look at the

Re: Close SqlSensor Connection

2018-01-16 Thread Bolke de Bruin
Of course. PR welcome. It would be nice to know how to test for connection leakage. Sent from my iPhone > On 16 Jan 2018, at 16:01, Alexis Rolland wrote: > > Hello everyone, > > I’m reaching out to discuss / suggest a small improvement in the class > SqlSensor:

Close SqlSensor Connection

2018-01-16 Thread Alexis Rolland
Hello everyone, I'm reaching out to discuss / suggest a small improvement in the class SqlSensor: https://pythonhosted.org/airflow/_modules/airflow/operators/sensors.html We are currently using SqlSensors on top of Teradata in several DAGs. When the DAGs execute we receive the following error

Close SqlSensor Connection

2018-01-16 Thread Alexis Rolland
[Edit: resending e-mail now that my account is whitelisted] Hello everyone, I'm reaching out to discuss / suggest a small improvement in the class SqlSensor: https://pythonhosted.org/airflow/_modules/airflow/operators/sensors.html We are currently using SqlSensors on top of Teradata in several

Close SqlSensor Connection

2018-01-15 Thread Alexis Rolland
Hello everyone, I'm reaching out to discuss / suggest a small improvement in the class SqlSensor: https://pythonhosted.org/airflow/_modules/airflow/operators/sensors.html We are currently using SqlSensors on top of Teradata in several DAGs. When the DAGs execute we receive the following error