[GitHub] arunma opened a new pull request #39: [AMATERASU-52] Implement AmaContext.datastores

arunma opened a new pull request #39: [AMATERASU-52] Implement AmaContext.datastores URL: https://github.com/apache/incubator-amaterasu/pull/39 This is an automated message from the Apache Git Service. To respond to the mess

Re: [jira] [Created] (AMATERASU-52) Implement AmaContext.datastores

Hi Guy, Yaniv and Nadiv, This PR just captures part of the issue - the datasets.yaml, ConfigManager and the testcases. The Integration with the AmaContext is yet to be done but I would like to get your thoughts on the implementation. Guy - W

[GitHub] roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores

roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores URL: https://github.com/apache/incubator-amaterasu/pull/39#discussion_r247366732 ## File path: leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/configuration/ConfigManag

[GitHub] roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores

roadan commented on a change in pull request #39: [AMATERASU-52] Implement AmaContext.datastores URL: https://github.com/apache/incubator-amaterasu/pull/39#discussion_r247366504 ## File path: leader-common/src/main/kotlin/org/apache/amaterasu/leader/common/configuration/ConfigManag

Re: [jira] [Created] (AMATERASU-52) Implement AmaContext.datastores

Hi Arun, I've added my comments to the PR, but good call, I agree @Nadav Har Tzvi should at least review as you both need to maintain compatible APIs. Cheers, Yaniv On Sun, Jan 13, 2019 at 10:21 PM Arun Manivannan wrote: > Hi Guy, Yaniv and Nadiv, > > This PR