Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-27 Thread Viraj Jasani
Created https://issues.apache.org/jira/browse/INFRA-23638 Thanks On Sat, Aug 27, 2022 at 10:42 PM 吴治国 wrote: > > we can enable autolink redirection from Github > > commit to Jira for Ambari. I can create similar Infra Jira as > > https://issues.apache.org/jira/browse/INFRA-21720 for Ambari. >

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-27 Thread 吴治国
> we can enable autolink redirection from Github > commit to Jira for Ambari. I can create similar Infra Jira as > https://issues.apache.org/jira/browse/INFRA-21720 for Ambari. It will be helpful, thank you Viraj! How about we also enable it for Bigtop? @Bigtop Community Best Regards, Zhiguo Wu >

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-27 Thread Brahma Reddy Battula
PR is merged for squash and merge. thanks for wei-chiu. and after this commit, all comments are going to dev@ambari.apache.org. We need to add other emails for notifications. >>we can enable autolink redirection from Github commit to Jira for AmbaI. It's good to have. On Fri, Aug 26, 2022 at

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-26 Thread Viraj Jasani
In addition to enabling "squash & merge" as default option, I also think, for the ease of tracking, we can enable autolink redirection from Github commit to Jira for Ambari. I can create similar Infra Jira as https://issues.apache.org/jira/browse/INFRA-21720 for Ambari. On Wed, Aug 24, 2022 at 8:

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-24 Thread Viraj Jasani
+1 (non-binding) for enforcing squash & merge as default (or only) option. On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang wrote: > In other projects that I work on, we enforce "squash and merge" when > merging a github PR. > > It makes commit history much cleaner, because a PR gets mapped to a

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-23 Thread Jun HE
Wei-Chiu Chuang > > Reply-To: "dev@ambari.apache.org" > > Date: Tuesday, 23 August 2022 at 10:22 PM > > To: "dev@ambari.apache.org" > > Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo > > >

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-23 Thread Battula, Brahma Reddy
ot;dev@ambari.apache.org" > Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo > > In other projects that I work on, we enforce "squash and merge" when merging a github PR. > > It makes commit history much cleane

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-23 Thread 吴治国
org" > Date: Tuesday, 23 August 2022 at 10:22 PM > To: "dev@ambari.apache.org" > Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo > > In other projects that I work on, we enforce "squash and merge" when merging > a

Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-23 Thread Battula, Brahma Reddy
+1, thanks for starting this thread. From: Wei-Chiu Chuang Reply-To: "dev@ambari.apache.org" Date: Tuesday, 23 August 2022 at 10:22 PM To: "dev@ambari.apache.org" Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo In other projects tha

[DISCUSS] Enable 'squash and merge' in Ambari's github repo

2022-08-23 Thread Wei-Chiu Chuang
In other projects that I work on, we enforce "squash and merge" when merging a github PR. It makes commit history much cleaner, because a PR gets mapped to a single git commit. Thoughts on this? I am making this recommendation because in the current Ambari git repo we end up with several commits.