Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28394/#review63054 --- Ship it! Ship It! - Nate Cole On Nov. 25, 2014, 12:33 a.m., Jona

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28394/ --- (Updated Nov. 25, 2014, 12:33 a.m.) Review request for Ambari, Nate Cole and To

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
> On Nov. 24, 2014, 5:33 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/HostInfo_linux.py, lines 218-223 > > > > > > Probably also modify HostInfo_win.py Thanks for the review; fixed. - Jonatha

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Jonathan Hurley
> On Nov. 24, 2014, 6:59 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java, > > lines 444-449 > > > > > > Is definitionId parameter needed? Thanks for the revi

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28394/#review62891 --- Ship it! Looks good. Just some minor comments... ambari-server/s

Re: Review Request 28394: Current Alerts Should Be Cleaned Up With Ambari Cluster/Service/Component/Host Changes

2014-11-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28394/#review62886 --- Ship it! ambari-agent/src/main/python/ambari_agent/HostInfo_linux.