Re: Review Request 28291: Alerts: Template Engine for Dispatching

> On Nov. 21, 2014, 5:39 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java, > > line 82 > > > > > > Should we be using javax.inject inste

Re: Review Request 28291: Alerts: Template Engine for Dispatching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291/#review62536 --- Ship it! Looks good. ambari-server/src/main/java/org/apache/ambar

Re: Review Request 28291: Alerts: Template Engine for Dispatching

> On Nov. 20, 2014, 9:52 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java, > > line 125 > > > > > > Nit: does this still work even if there

Re: Review Request 28291: Alerts: Template Engine for Dispatching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291/#review62517 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/noti

Re: Review Request 28291: Alerts: Template Engine for Dispatching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291/ --- (Updated Nov. 20, 2014, 2:16 p.m.) Review request for Ambari, Nate Cole, Sriman

Review Request 28291: Alerts: Template Engine for Dispatching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28291/ --- Review request for Ambari, Nate Cole, Srimanth Gunturi, and Tom Beerbower. Bugs