Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/#review69171 --- Ship it!

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/#review69174 --- Ship it! Ship It! - Nate Cole On Jan. 22, 2015, 8:05 a.m.,

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread Nate Cole
On Jan. 22, 2015, 8:25 a.m., Tom Beerbower wrote: ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java, line 640 https://reviews.apache.org/r/28851/diff/2/?file=829785#file829785line640 I wonder if this class and TokenHandler should be static. They

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/ --- (Updated Янв. 22, 2015, 1:05 п.п.) Review request for Ambari, John Speidel,

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread John Speidel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/#review69193 --- Ship it! Ship It! - John Speidel On Jan. 22, 2015, 1:05 p.m.,

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

2015-01-22 Thread Dmytro Sen
On Янв. 22, 2015, 1:25 п.п., Tom Beerbower wrote: ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java, line 640 https://reviews.apache.org/r/28851/diff/2/?file=829785#file829785line640 I wonder if this class and TokenHandler should be static. They

Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR

2014-12-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/ --- Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower. Bugs:

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR

2014-12-09 Thread John Speidel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28851/#review64461 --- This patch should be split into 2 patches. One for the Lexer