Re: Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services

2014-12-10 Thread John Speidel
> On Dec. 10, 2014, 11:01 p.m., John Speidel wrote: > > looks like you need to rebase your patch never mind, seems that it was already pushed but the review wasn't closed - John --- This is an automatically generated e-mail. To reply, v

Re: Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services

2014-12-10 Thread John Speidel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28901/#review64655 --- looks like you need to rebase your patch - John Speidel On Dec. 1

Re: Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services

2014-12-10 Thread Robert Levas
> On Dec. 10, 2014, 10:33 a.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java, > > line 200 > > > > > > just wanted to be sure that it is ok

Re: Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services

2014-12-10 Thread John Speidel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28901/#review64547 --- Ship it! looks good ambari-server/src/main/java/org/apache/ambari

Review Request 28901: Allow for service-level Kerberos descriptor to contain multiple services

2014-12-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28901/ --- Review request for Ambari, Jaimin Jetly, John Speidel, Robert Nettleton, and Yus