Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Andrew Onischuk
On March 5, 2015, 1:15 p.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Jonathan Hurley wrote: Agreed; why is the separate script necessary?

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Andrew Onischuk
On March 5, 2015, 1:15 p.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Jonathan Hurley wrote: Agreed; why is the separate script necessary?

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Alejandro Fernandez
On March 5, 2015, 1:15 p.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Jonathan Hurley wrote: Agreed; why is the separate script necessary?

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31752/#review75315 --- Why would that make any change? The binary is in PATH and works in

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Andrew Onischuk
On March 5, 2015, 1:15 p.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Jonathan Hurley wrote: Agreed; why is the separate script necessary?

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Jonathan Hurley
On March 5, 2015, 8:15 a.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Jonathan Hurley wrote: Agreed; why is the separate script necessary?

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Jonathan Hurley
On March 5, 2015, 8:15 a.m., Nate Cole wrote: Seems like we should be abstracting somehow - maybe with an ExecuteSudo or something that takes the same exact arguments as Execute, but does all this sudo voodoo. Agreed; why is the separate script necessary? I even thought that the

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31752/#review75325 --- Seems like we should be abstracting somehow - maybe with an

Re: Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-04 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31752/#review75273 --- ambari-common/src/main/python/ambari_commons/constants.py

Review Request 31752: ambari-sudo.sh needs full path, install fails if JDK is not installed

2015-03-04 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31752/ --- Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and Sid