Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Alejandro Fernandez
> On June 4, 2015, 4:39 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 77 > > > > > > Do we really need ignore any exceptions here, and

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86644 --- ambari-common/src/main/python/resource_management/libraries/functio

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/ --- (Updated June 4, 2015, 4:37 p.m.) Review request for Ambari, Andrew Onischuk, D

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Andrew Onischuk
> On June 4, 2015, 2:48 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 64 > > > > > > Do we close this one somewhere? > > Can we imp

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86620 --- ambari-common/src/main/python/resource_management/libraries/functio

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Alejandro Fernandez
> On June 4, 2015, 2:50 a.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 64 > > > > > > I think we need to use the temp directory defined

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Alejandro Fernandez
> On June 4, 2015, 8:25 a.m., Dmitro Lisnichenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 175 > > > > > > we should probably use only one string format

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Andrew Onischuk
> On June 4, 2015, 2:50 a.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 64 > > > > > > I think we need to use the temp directory defined

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Nate Cole
> On June 3, 2015, 10:50 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 64 > > > > > > I think we need to use the temp directory defined

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Andrew Onischuk
> On June 4, 2015, 2:50 a.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 64 > > > > > > I think we need to use the temp directory defined

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86587 --- Ship it! Once the fixes are in that other folks brought up, I'm goo

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Nate Cole
> On June 3, 2015, 10:50 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 70 > > > > > > Any reason you're writing this to a file instead

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86575 --- Ship it! ambari-common/src/main/python/resource_management/librari

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86540 --- Ship it! ambari-common/src/main/python/resource_management/librari

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-03 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/#review86538 --- Ship it! Ship It! - Srimanth Gunturi On June 4, 2015, 12:23 a.m.

Re: Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/ --- (Updated June 4, 2015, 12:23 a.m.) Review request for Ambari, Andrew Onischuk,

Review Request 34982: During initial Stack Install, tarballs will not be copied to HDFS because the current_version is not yet known

2015-06-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34982/ --- Review request for Ambari. Bugs: AMBARI-11640 https://issues.apache.org/jir